Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to hide dismiss button and timer for BillboardBannerView #26

Merged
merged 2 commits into from
Oct 29, 2023
Merged

option to hide dismiss button and timer for BillboardBannerView #26

merged 2 commits into from
Oct 29, 2023

Conversation

dhaydl
Copy link
Contributor

@dhaydl dhaydl commented Oct 22, 2023

I implemented Billboard in my app and recognized that I need the option to hide the dismiss button for BillboardBannerView. Maybe this could be incorporated into the main package?

hiddevdploeg
hiddevdploeg requested changes Oct 29, 2023
View reviewed changes
Copy link
Owner

@hiddevdploeg hiddevdploeg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this addition! However, I think this should be part of the BillboardConfiguration and not of the BillboardBannerView :)

Scratch that, this makes sense! Thanks for the addition

@hiddevdploeg hiddevdploeg self-requested a review October 29, 2023 11:01
@hiddevdploeg hiddevdploeg merged commit 267779b into hiddevdploeg:main Oct 29, 2023
1 check passed
@dhaydl
Copy link
Contributor Author

dhaydl commented Oct 31, 2023

I've seen BillboardConfiguration, but as you recognized your self, putting the flag in there would've been kinda counter intuitive. Thanks for merging 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddevdploeg hiddevdploeg hiddevdploeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaydl @hiddevdploeg