docs: Add test specifications for AccountAllowanceDeleteTransaction
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
…tion' into 00027-document-e2e-tests-accountallowancedeletetransaction
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
rwalworth
requested review from
0xivanov,
RickyLB,
agadzhalov,
jsync-swirlds,
gsstoykov and
ivaylogarnev-limechain
0xivanov
reviewed
Nov 22, 2024
| @@ -0,0 +1,245 @@ | |||
| # AccountAllowanceApproveTransaction - Test specification | |||
There was a problem hiding this comment.
Does this file need to be in this PR? I believe it's already implemented in separate PR.
0xivanov
reviewed
Nov 22, 2024
test-specifications/crypto-service/accountAllowanceDeleteTransaction.md
Outdated
Show resolved
Hide resolved
test-specifications/crypto-service/accountAllowanceDeleteTransaction.md
Outdated
Show resolved
Hide resolved
test-specifications/crypto-service/accountAllowanceDeleteTransaction.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
I guess I got lazy with my copy-pasting! There are deprecated methods but these only make modifications to local class variables that don't ever actually get sent to the network. I didn't think these were necessary to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the test specifications for
AccountAllowanceDeleteTransactionfields.Related Issue(s):
Fixes #27
Notes for Reviewer(s):
This PR contains work in #279 so that should be reviewed and merged first.
Checklist