Add Uniswap V3 Price Feed #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor perf(protocol): add minor gas optimizations to UniswapV3Pool feat(protocol): add "IUniswapV3PriceFeed__RefAssetNotInPool" error in UniswapV3PriceFeed.sol refactor(protocol): add UniswapV3PriceFeed interface docs(protocol): add missing "@inheritdoc" tags in UniswapV3PriceFeed.sol refactor(protocol): rename "getNormalizedPriceInternal" function into "getPriceInternal"
chore(protocol): re-generate types
…rotocol/tasks/deploy/index.ts"
chore(protocol): re-generate types
perf(protocol): remove "basePrice" memory var from "getPriceInternal" function perf(protocol): use "1 << 192" instead of "2**192" for gas savings refactor(protocol): rename "normalizedPrice" to "price" in "getPriceInternal" function
…etPriceInternal" function
test(protocol): add UniswapV3PriceFeed deployer test(protocol): add UniswapV3PriceFeed fixture test(protocol): add UniswapV3Pool mock test(protocol): test "description" function in UniswapV3PriceFeed test(protocol): test "pool" function in UniswapV3PriceFeed test(protocol): test "refAsset" function in UniswapV3PriceFeed test(protocol): test "twapInterval" function in UniswapV3PriceFeed chore(protocol): re-generate types
test(protocol): test "latestRoundData" function in UniswapV3PriceFeed
test(protocol): test "version" function in UniswapV3PriceFeed
test(protocol): add more unit tests for "getRoundData" and "latestRoundData" functions chore(protocol): re-generate types
… immutable vars test(protocol): update unit tests to integrate GodModeUniswapV3PriceFeed chore(protocol): re-generate types
…s.ts build(protocol): add "@uniswap/v3-sdk" dev dep feat(constants): add Uniswap V3 constants test(protocol): update unit tests for "getRoundData" function to reflect added mirrors test(protocol): update unit tests for "latestRoundData" function to reflect added mirrors chore(protocol): re-generate types
perf(protocol): add token{0,1} as immutable variables
refactor(protocol): switch token{0,1}Decimals to uint8
test(protocol): test both branches of "description" function in UniswapV3PriceFeed
test(protocol): make UniswapV3PriceFeed unit tests more descriptive
refactor(constants): rename "uniswap-v3.ts" to "oracles.ts"
chore(protocol): re-generate types
chore(protocol): re-generate types
scorpion9979
force-pushed
the
feat/uniswap-v3-price-feed
branch
from
81ca0e3
to
ac2aa67
Compare
…ol and related interfaces chore(protocol): disable solhint linter rules for "external" contract files
feat(protocol): check provided pool address is not zero in UniswapV3PriceFeed constructor refactor(protocol): clean up IUniswapV3Pool
chore(protocol): re-generate types
feat(errors): add oracle errors feat(constants): add "CARDINALITY" constant
chore(protocol): re-generate types
test(protocol): add unit test for "baseAsset" chore(protocol): re-generate types
…ceFeed chore(protocol): re-generate types
… constructor test(protocol): fix UniswapV3PriceFeed tests chore(protocol): re-generate types
… error test(protocol): update UniswapV3PriceFeed tests chore(protocol): re-generate types
test(protocol): remove unused import
…value docs(protocol): add comments to UniswapV3PriceFeed constructor feat(constants): change default oracle params to 30-minute TWAP refactor(constants): rename "CARDINALITY" to "DEFAULT_CARDINALITY"
feat(errors): add MAX_PRICE_LESS_THAN_OR_EQUAL_TO_ZERO test(protocol): add "setMaxPrice" unit test chore(protocol): re-generate types
… of "cardinality" chore(protocol): re-generate types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for Chainlink-compatible Uniswap V3 price feeds.