Lib test #5
Open
Lib test #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CRMGB
commented
Jul 4, 2023
CRMGB
commented
- Unit-tests added for the logdadta.py file using the features of process_download_logs.py.
- Added typing annotations to every python file.
- Run Flake8 through all files.
- Added f strings to all strings where needed.
- Modified the exception handling.
- Minor changes like moving all the env variables to the process_download_logs.py to help me testing.
- Moved the method 'line_to_request' to the LogStream class and renamed to 'check_url_matches' to help me testing and make the code more understandable.
- Ignore calling the class Request if the request is malformed.
- Place an underscore in the unused variables.
…g to get the logs
…re clear instead of a monosibly words which might be confusing. Added a test for the class requests, a few more tests pendant
… gets closed, still [pendant to create the tests for proccess download
…s so it could be tested easier, corrections to tests and added missing typing annotations, moved over the parse_url so it's cleaner
…ing, replaced most of the real data with dummy data, and deleted test files in the teardown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.