Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UE] make text blocks editable with Universal Editor #1117

Merged
merged 10 commits into from
May 27, 2024
Merged

[UE] make text blocks editable with Universal Editor #1117

merged 10 commits into from
May 27, 2024

Conversation

jckautzmann
Copy link
Collaborator

@jckautzmann jckautzmann commented May 16, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1083

Test URLs:

@jckautzmann
[UE] Implement UE support for "topics" pages
a1e68b9 
- make text block UE editable
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented May 16, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented May 16, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@jckautzmann jckautzmann requested a review from buuhuu May 16, 2024 14:48
@aem-code-sync aem-code-sync bot temporarily deployed to ue-text-editable May 21, 2024 13:00 Inactive
@jckautzmann
[UE] make text block UE editable
0b41b3a 
- small change to trigger GH actions
@jckautzmann
[UE] make text block UE editable
a3a7d17 
- small change to trigger GH actions
@jckautzmann jckautzmann changed the title [UE] Implement UE support for "topics" pages [UE] make text blocks editable with Universal Editor May 21, 2024
@jckautzmann
Copy link
Collaborator Author

Please note: as aem.js is not backwards compatible with its former version lib-franklin.js , aem.js has been ported to the Danaher project and is only used in the code supporting UE editing editor-support.js.

buuhuu
buuhuu requested changes May 24, 2024
View reviewed changes
scripts/aem.js Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is rather old. The changes in aem.js should be incorporated into the lib-franklin.js

@jckautzmann
Merge branch 'main' into ue-text-editable
eed3f56
@jckautzmann
[UE] make text block UE editable
7ac27ee 
- remove aem.js and update lib-franklin.js from latest aem.js
@jckautzmann
[UE] make text block UE editable
a1147ca 
- add a temporary console log to check pages
@buuhuu buuhuu self-requested a review May 27, 2024 13:08
@jckautzmann
[UE] make text block UE editable
798205d 
- remove the temporary console log to check pages
@jckautzmann jckautzmann merged commit 5513809 into main May 27, 2024
2 checks passed
@jckautzmann jckautzmann deleted the ue-text-editable branch May 27, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buuhuu buuhuu buuhuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UE] Implement UE support for "topics" pages
2 participants
@jckautzmann @buuhuu