Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1154 [SEO] Converter update Embed Placeholder #1195

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

sharanagoudapatil
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1154

Test URLs:

@sharanagoudapatil sharanagoudapatil linked an issue Jul 1, 2024 that may be closed by this pull request
Copy link
Contributor

aem-code-sync bot commented Jul 1, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jul 1, 2024

Page Scores Audits Google
/us/en/about-us/about-us-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sharanagoudapatil sharanagoudapatil changed the title 1154 [SEO] Embed Placeholder 1154 [SEO] Converter update Embed Placeholder Jul 1, 2024
@sharanagoudapatil sharanagoudapatil marked this pull request as draft July 1, 2024 11:30
@sharanagoudapatil sharanagoudapatil marked this pull request as ready for review July 5, 2024 04:20
@aem-code-sync aem-code-sync bot temporarily deployed to 1154-embed-placeholder July 5, 2024 04:20 Inactive
@rgravitvl
Copy link
Collaborator

rgravitvl commented Jul 9, 2024

@sharanagoudapatil LGTM. But before merge please fix the converter test cases and proceed. Thanks.

@rgravitvl - I've updated the test cases. Thanks.

@aem-code-sync aem-code-sync bot temporarily deployed to 1154-embed-placeholder July 19, 2024 04:41 Inactive
@sharanagoudapatil sharanagoudapatil merged commit bcf26e6 into main Jul 19, 2024
3 checks passed
@sharanagoudapatil sharanagoudapatil deleted the 1154-embed-placeholder branch July 19, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SEO] Embed Placeholder
2 participants