Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1242 [Forms] Implement the SFDC forms for Franklin #1253

Merged
merged 6 commits into from
Aug 13, 2024
Merged

1242 [Forms] Implement the SFDC forms for Franklin #1253

merged 6 commits into from
Aug 13, 2024

Conversation

sharanagoudapatil
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1242

Test URLs:

@sharanagoudapatil sharanagoudapatil linked an issue Aug 7, 2024 that may be closed by this pull request
[Forms] Implement the SFDC forms for Franklin #1242
Closed
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Aug 7, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@sharanagoudapatil sharanagoudapatil marked this pull request as draft August 7, 2024 12:03
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Aug 7, 2024 •
edited
Loading

Page Scores Audits Google
/us/en/solutions/mabs/cell-line-development/expert-bak PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 1242-forms-ttae-franklin August 7, 2024 13:03 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 1242-forms-ttae-franklin August 7, 2024 16:05 Inactive
@sharanagoudapatil sharanagoudapatil marked this pull request as ready for review August 7, 2024 16:08
@aem-code-sync aem-code-sync bot temporarily deployed to 1242-forms-ttae-franklin August 8, 2024 06:10 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 1242-forms-ttae-franklin August 12, 2024 06:31 Inactive
davenichols-DHLS
davenichols-DHLS approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@davenichols-DHLS davenichols-DHLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@davenichols-DHLS davenichols-DHLS merged commit 1407b91 into main Aug 13, 2024
2 checks passed
@davenichols-DHLS davenichols-DHLS deleted the 1242-forms-ttae-franklin branch August 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgravitvl rgravitvl rgravitvl approved these changes

@davenichols-DHLS davenichols-DHLS davenichols-DHLS approved these changes

@amlan18041996 amlan18041996 Awaiting requested review from amlan18041996

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Forms] Implement the SFDC forms for Franklin
3 participants
@sharanagoudapatil @rgravitvl @davenichols-DHLS