Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1259-homepage-carousel #1262

Merged
merged 3 commits into from
Aug 22, 2024
Merged

1259-homepage-carousel #1262

merged 3 commits into from
Aug 22, 2024

Conversation

davenichols-DHLS
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1259

Test URLs:

@davenichols-DHLS davenichols-DHLS linked an issue Aug 21, 2024 that may be closed by this pull request
[Bug] Homepage Carousel #1259
Closed
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Aug 21, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Aug 21, 2024 •
edited
Loading

Page Scores Audits Google
M / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 1259-homepage-carousel August 21, 2024 16:54 Inactive
sharanagoudapatil
sharanagoudapatil approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@sharanagoudapatil sharanagoudapatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Thanks

@davenichols-DHLS davenichols-DHLS merged commit 4f61944 into main Aug 22, 2024
2 checks passed
@davenichols-DHLS davenichols-DHLS deleted the 1259-homepage-carousel branch August 22, 2024 09:08
@davenichols-DHLS davenichols-DHLS restored the 1259-homepage-carousel branch August 22, 2024 17:58
@aem-code-sync aem-code-sync bot temporarily deployed to 1259-homepage-carousel August 22, 2024 17:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharanagoudapatil sharanagoudapatil sharanagoudapatil approved these changes

@rgravitvl rgravitvl Awaiting requested review from rgravitvl

@amlan18041996 amlan18041996 Awaiting requested review from amlan18041996

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Homepage Carousel
2 participants
@davenichols-DHLS @sharanagoudapatil