Issue 48 - Use high resolution assets when possible #52
Conversation
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
| @@ -63,6 +63,13 @@ const REL_RENDITIONS = 'http://ns.adobe.com/adobecloud/rel/rendition'; | |||
| // TODO: change this to Asset Link IMS client ID | |||
| const IMS_CLIENT_ID = 'p66302-franklin'; | |||
| const ASSET_SELECTOR_ID = 'asset-selector'; | |||
| const CLIPBOARD_SUPPORTED_BINARY_MIMETYPES = [ | |||
There was a problem hiding this comment.
Mimetypes supported "natively" by the clipboard API (from the browser)
| const CLIPBOARD_SUPPORTED_BINARY_MIMETYPES = [ | ||
| 'image/png', | ||
| ]; | ||
| const SUPPORTED_RENDITIONS_FORMATS = [ |
There was a problem hiding this comment.
Renditions mimetypes that we can use in Franklin documents (needed for filtering).
| .forEach((rendition) => { | ||
| if ((!maxRendition || maxRendition.width < rendition.width)) { | ||
| if (SUPPORTED_RENDITIONS_FORMATS.includes(rendition.type) |
There was a problem hiding this comment.
Only look at mimetypes we can convert to use with the clipboard APIs...
| @@ -325,9 +375,9 @@ export async function copyAssetWithRapi(asset) { | |||
| logMessage('Rendition download JSON not provided'); | |||
| return false; | |||
| } | |||
| await copyToClipboardWithBinary(downloadJson.href, downloadJson.type); | |||
| await copyToClipboardWithBinary(downloadJson.href, downloadJson.type, asset); | |||
There was a problem hiding this comment.
Asset info is needed to give the canvas the proper size
No, the latency seems to come from AEM things loading. I had (high) latency with copying and loading the whole day, before and after making those changes, before and after those changes. (I often hit intial loading times of 5-10 mins for the screen listing the assets). |
Fix #48
Allows higher resolution selections by allowing more mimetypes to be picked as the rendition to use than only PNG.
When a JPEG asset is picked, it is converted into a PNG blog using a canvas.
Currently only JPEG and PNG mimetypes are supported, but the list can be extended in the future as the support for image conversion improves, and once we test and validate that it works.