Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 50 - Remove header and footer (since they're not used) #53

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

tmathern
Copy link

@tmathern tmathern commented Aug 23, 2023

Fix #50

  • Remove header and footer (since they're not used)
  • Remove unused icon

Test Url: https://issue-50--franklin-assets-selector--hlxsites.hlx.live/aem-asset-selector

@tmathern tmathern self-assigned this Aug 23, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 23, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 24, 2023

Page Scores Audits Google
/aem-asset-selector PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 24, 2023

Page Scores Audits Google
/aem-asset-selector PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sdmcraft sdmcraft merged commit aa04451 into main Aug 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omit unnecessary calls for header/footer
3 participants