Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict filters to images #57

Merged
merged 4 commits into from
Aug 26, 2023
Merged

Restrict filters to images #57

merged 4 commits into from
Aug 26, 2023

Conversation

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 24, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 24, 2023

Page Scores Audits Google
/aem-asset-selector PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

},
{
label: 'GIF',
value: 'image/gif',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also add webp here once we've tested it works with getting high res assets (canvas supports it, we just didn't have the assets to test and I don't have enough permissions to add assets...).

Copy link

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - but with a caveat: does it let us still see folders? Because without a good tree navigation, showing folders in the same view is the only way we got to navigate.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/aem-asset-selector PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sdmcraft
Copy link
Collaborator Author

Approving - but with a caveat: does it let us still see folders? Because without a good tree navigation, showing folders in the same view is the only way we got to navigate.

Good call out! Yes it seems to remove the folders from view. Following up on this here.

* With directories
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 26, 2023

Page Scores Audits Google
/aem-asset-selector PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sdmcraft sdmcraft merged commit 245cb7a into main Aug 26, 2023
2 checks passed
@tmathern tmathern deleted the i-56 branch August 28, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict asset selector to show up only images
2 participants