EXUI-705: Action dev review comments

hmcts · Aug 17, 2023 · c4c4558 · c4c4558
1 parent cdc1665
commit c4c4558
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/.github/workflows/dependency-check.yml b/.github/workflows/dependency-check.yml
@@ -1,9 +1,12 @@
-name: Suppressions
+name: Automated update of known-issue suppression
 
 on:
+  pull_request:
+    branches:
+      - master
   schedule:
-    # At 12 midnight and every 3rd hour from 10am through 11pm
-    - cron: "0 0,10-23/3 * * *"
+    # At 12 midnight, 7am and 5pm
+    - cron: "0 0,7,17 * * *"
   workflow_dispatch:
 
 jobs:
@@ -22,11 +25,11 @@ jobs:
       - uses: actions/setup-node@v1
         with:
           node-version: 16
-      - name: Run dependencyCheck
-        run: yarn audit
+      - name: Run automated update of known-issue suppression
+        run: yarn update-audit-known-issues
       - name: Commit
         uses: stefanzweifel/git-auto-commit-action@v4
         with:
           skip_dirty_check: false
-          commit_message: "Suppressing CVE - Actions"
+          commit_message: "Automated update of known-issue suppression"
           branch: master
diff --git a/package.json b/package.json
@@ -5,7 +5,6 @@
     "node": ">=12.13.0"
   },
   "scripts": {
-    "audit": "yarn npm audit --recursive --environment production --json > yarn-audit-known-issues",
     "build": "yarn build:prod && yarn build:node",
     "build:docker": "docker build -t xui .",
     "build:ng": "node --max_old_space_size=8192 node_modules/@angular/cli/bin/ng build --prod build",
@@ -70,7 +69,8 @@
     "test:codeceptE2EDebug": "TEST_TYPE=e2e  npx codeceptjs run  --plugins retryFailedStep --config=./test_codecept/codeceptCommon/codecept.conf.ts  --features --grep @codecept_test --reporter mochawesome ",
     "test:codeceptE2E": "TEST_TYPE=e2e  npx codeceptjs run-workers --suites 5 --plugins retryFailedStep --config=./test_codecept/codeceptCommon/codecept.conf.ts  --features --grep @codecept_enabled --reporter mochawesome ",
     "test:xuiIntegrationDebug": "NODE_CONFIG_ENV=mock TEST_TYPE=ngIntegration TEST_URL=http://localhost:3000  npx codeceptjs run  --config=./test_codecept/codeceptCommon/codecept.conf.ts  --features --grep @codecept_test --reporter mochawesome ",
-    "test:xuiIntegration": "yarn build && node ./test_codecept/backendMock/configCopy.js && NODE_CONFIG_ENV=mock TEST_TYPE=ngIntegration PARALLEL=true  npx codeceptjs run-workers --suites 5  --config=./test_codecept/codeceptCommon/codecept.conf.ts  --features --grep @codecept_enabled --reporter mochawesome "
+    "test:xuiIntegration": "yarn build && node ./test_codecept/backendMock/configCopy.js && NODE_CONFIG_ENV=mock TEST_TYPE=ngIntegration PARALLEL=true  npx codeceptjs run-workers --suites 5  --config=./test_codecept/codeceptCommon/codecept.conf.ts  --features --grep @codecept_enabled --reporter mochawesome ",
+    "update-audit-known-issues": "yarn npm audit --recursive --environment production --json > yarn-audit-known-issues"
   },
   "private": true,
   "dependencies": {