Hearings Post Go Live 1.2 v3 #3201

johnbenjamin-hmcts · 2023-08-07T16:18:44Z

JIRA link (if applicable)

EPIC - https://tools.hmcts.net/jira/browse/EUI-7800
EPIC - https://tools.hmcts.net/jira/browse/EUI-7918

https://tools.hmcts.net/jira/browse/EUI-7916
https://tools.hmcts.net/jira/browse/EUI-7922
https://tools.hmcts.net/jira/browse/EUI-6798
https://tools.hmcts.net/jira/browse/EUI-7896
https://tools.hmcts.net/jira/browse/EUI-9005
https://tools.hmcts.net/jira/browse/EUI-7939
https://tools.hmcts.net/jira/browse/EUI-7936

https://tools.hmcts.net/jira/browse/COT-515
https://tools.hmcts.net/jira/browse/COT-354
https://tools.hmcts.net/jira/browse/COT-599
https://tools.hmcts.net/jira/browse/COT-442
https://tools.hmcts.net/jira/browse/COT-540

Change description

EUI-7800 - Hearings Post Go Live 1.2
EUI-7918 - Hearings onboarding CIVIL

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

…irmed

…ing-error-when-participants-are-not-confirmed EUI-7916 Hearing Actuals getting error when participants are not confirmed

…cipants

…own-error-when-confirming-time-and-participants EUI-7922 Hearing Actuals unknown error when confirming time and participants

…6-Hearings-CIVIL-Integration-initial-request

…8-Hearings-tab-display-by-case-type-basis

…play-by-case-type-basis EUI-6798 Hearings tab display by case type basis

…ntegration-initial-request EUI-7896 Hearings Civil integration initial request

…nsformation

…ibility-based-on-roles EUI-9005 Hearings tab visibility based on roles

* Update labels for future hearings to "FUTURE HEARING DAY" and hide all change/update links for future hearing days * Fix minor styling issue * Add units test for hearingIsInFuture * Fix linting errors

This reverts commit 98d575f.

Revert "Bug/cot 580"

Daniel-Lam

@johnbenjamin-hmcts - some comments to address, thanks

Daniel-Lam · 2023-11-29T11:40:31Z

src/cases/containers/case-hearings/case-hearings.component.spec.ts

}
+

@johnbenjamin-hmcts - really minor one, extra whitespace here...?

Daniel-Lam · 2023-11-29T11:44:43Z

src/cases/containers/case-hearings/case-hearings.component.spec.ts

@@ -26,14 +26,15 @@ import { LovRefDataModel } from '../../../hearings/models/lovRefData.model';
 import { LovRefDataService } from '../../../hearings/services/lov-ref-data.service';
 import * as fromHearingStore from '../../../hearings/store';
 import { CaseHearingsComponent } from './case-hearings.component';
+import { SessionStorageService } from '../../../app/services';


@johnbenjamin-hmcts - please check ordering of imports

Daniel-Lam · 2023-11-29T11:45:34Z

src/cases/containers/case-hearings/case-hearings.component.ts

@@ -22,6 +21,7 @@ import {
 import { LovRefDataModel } from '../../../hearings/models/lovRefData.model';
 import { LovRefDataService } from '../../../hearings/services/lov-ref-data.service';
 import * as fromHearingStore from '../../../hearings/store';
+import { SessionStorageService } from '../../../app/services';


@johnbenjamin-hmcts - please check ordering of imports

Daniel-Lam · 2023-11-29T11:46:49Z

src/cases/containers/case-hearings/case-hearings.component.ts

+    const detailsStr = this.sessionSvc.getItem('userDetails');
+    if (detailsStr) {
+      const details = JSON.parse(detailsStr) as object;
+      if (details && details.hasOwnProperty('roles')) {


@johnbenjamin-hmcts - can be rewritten with optional chaining, i.e. details?.hasOwnProperty('roles')

Daniel-Lam · 2023-11-29T11:52:09Z

src/cases/utils/utils.ts

-        return featureVariation.roles ? userRoles.some((userRole) =>
-          featureVariation.roles.some((role) => role === userRole)) : false;
+  public static hasMatchedJurisdictionAndCaseType(featureVariation: FeatureVariation, jurisdictionId: string, caseType: string): boolean {
+    if (featureVariation.jurisdiction === jurisdictionId) {


@johnbenjamin-hmcts - given the function returns either true or false, I think you could rewrite this using a ternary statement. Also, the optional check (i.e. ?) on Line 62 is somewhat redundant because Line 61 assumes featureVariation is truthy

Daniel-Lam · 2023-11-29T11:53:53Z

...ing-actuals/hearing-actuals-view-edit-parties/hearing-actuals-view-edit-parties.component.ts

-      } else {
-        this.mutablePartyRoles.push(role);
-      }
+      this.mutablePartyRoles.push(role);


@johnbenjamin-hmcts - is mutablePartyRoles guaranteed to be truthy at this point?

Daniel-Lam · 2023-11-29T11:55:32Z

src/hearings/converters/reasonable-adjustments.amended.converter.spec.ts

@@ -0,0 +1,114 @@
+import { cold } from 'jasmine-marbles';


@johnbenjamin-hmcts - please check import ordering

Daniel-Lam · 2023-11-29T11:56:31Z

src/hearings/converters/reasonable-adjustments.amended.converter.ts

@@ -0,0 +1,28 @@
+import * as _ from 'lodash';


@johnbenjamin-hmcts - please check import ordering

Daniel-Lam · 2023-11-29T11:58:12Z

src/hearings/services/hearings.service.spec.ts

      }
    };

    it('should update hearing request', inject([HttpTestingController, HearingsService], (httpMock: HttpTestingController, service: HearingsService) => {
      service.updateHearingRequest(payload).subscribe((response) => {
+        console.log('RESPONSE', JSON.stringify(response));


@johnbenjamin-hmcts - can remove console.log statements

Daniel-Lam · 2023-11-29T11:59:10Z

src/hearings/utils/validators.utils.spec.ts

@@ -220,4 +222,52 @@ describe('ValidatorsUtils', () => {
    const result = service.validateDuplicateEntries(1, 'Duplicate entry')(evaluatedForm);
    expect(result.hasOwnProperty('duplicateEntries')).toBeTruthy();
  }));
+
+  it('should return HearingWindowModel NULL when hearingWidnow is an empty object', inject([ValidatorsUtils], (service: ValidatorsUtils) => {


@johnbenjamin-hmcts - typo on "hearingWidnow"

johnbenjamin-hmcts and others added 30 commits March 6, 2023 10:43

EUI-7916 Hearing Actuals getting error when participants are not conf…

c7ab533

…irmed

EUI-7916 Hearing Actuals getting error when participants are not conf…

d76933b

…irmed

Merge pull request #2833 from hmcts/bug/EUI-7916-Hearing-Actuals-gett…

1c09550

…ing-error-when-participants-are-not-confirmed EUI-7916 Hearing Actuals getting error when participants are not confirmed

EUI-7922 Hearing Actuals unknown error when confirming time and parti…

b4eaecf

…cipants

Merge pull request #2834 from hmcts/bug/EUI-7922-Hearing-Actuals-unkn…

d63888e

…own-error-when-confirming-time-and-participants EUI-7922 Hearing Actuals unknown error when confirming time and participants

Hearings Actuals planned to actual transformation

907d856

EUI-7927 Hearings Actuals planned to actual transformation

9bd2d04

EUI-7927 Hearings Actuals planned to actual transformation

5ecab9a

EUI-7927 Hearings Actuals planned to actual transformation

73ed24c

EUI-7927 Hearings Actuals planned to actual transformation

8cf307b

EUI-7927 Hearings Actuals planned to actual transformation

eb7ecb1

EUI-7896 Hearings CIVIL Integration initial request

c99fe23

Merge branch 'feature/Hearings-Post-Go-Live-1.2' into feature/EUI-789…

dbc74fd

…6-Hearings-CIVIL-Integration-initial-request

Merge branch 'master' into feature/Hearings-Post-Go-Live-1.2

e4679fc

Merge branch 'feature/Hearings-Post-Go-Live-1.2' into feature/EUI-789…

2bb4b1c

…6-Hearings-CIVIL-Integration-initial-request

Merge branch 'feature/Hearings-Post-Go-Live-1.2' into feature/EUI-679…

d1c9f22

…8-Hearings-tab-display-by-case-type-basis

Merge pull request #2814 from hmcts/feature/EUI-6798-Hearings-tab-dis…

d68ade4

…play-by-case-type-basis EUI-6798 Hearings tab display by case type basis

Merge branch 'master' into feature/Hearings-Post-Go-Live-1.2

821c1eb

Merge from master package json file

4c81fc2

Update yarn.lock

2b83400

Update package.json

96e56bb

Update yarn.lock

8179c78

Update yarn-audit-known-issues

0cd6f41

Merge pull request #2845 from hmcts/feature/EUI-7896-Hearings-CIVIL-I…

aeabe0b

…ntegration-initial-request EUI-7896 Hearings Civil integration initial request

Merge branch 'master' into bug/Hearings-Actuals-planned-to-actual-tra…

90fae3e

…nsformation

Merge with master

5384789

Merge from Master

4eeff96

Sonarcloud fixes

f7e71b8

EUI-7980 Link hearings only allow linking with an active hearing

1a45b08

EUI-7980 Link hearings only allow linking with an active hearing

68d377b

hmcts-jenkins-j-to-z bot deployed to preview November 20, 2023 13:29 View deployment

johnbenjamin-hmcts and others added 3 commits November 21, 2023 10:16

EUI-9005 Hearings tab visibility based on roles

656820b

test update inline with feature fix

38c9074

Merge pull request #3381 from hmcts/feature/EUI-9005-Hearings-tab-vis…

71f472e

…ibility-based-on-roles EUI-9005 Hearings tab visibility based on roles

hmcts-jenkins-j-to-z bot deployed to preview November 22, 2023 12:26 View deployment

hmcts-jenkins-j-to-z bot deployed to preview November 24, 2023 13:37 View deployment

hmcts-jenkins-j-to-z bot deployed to preview November 27, 2023 11:22 View deployment

udaydenduluri33 previously approved these changes Nov 27, 2023

View reviewed changes

andywilkinshmcts previously approved these changes Nov 27, 2023

View reviewed changes

hmcts-jenkins-j-to-z bot deployed to preview November 27, 2023 12:11 View deployment

hmcts-jenkins-j-to-z bot deployed to preview November 27, 2023 13:12 View deployment

hmcts-jenkins-j-to-z bot deployed to preview November 27, 2023 14:09 View deployment

FEATURE_JRD_E_LINKS_V2_ENABLED enabled to true

0873d27

udaydenduluri33 dismissed stale reviews from andywilkinshmcts and themself via 0873d27 November 28, 2023 10:23

yarn audit

d6af9de

hmcts-jenkins-j-to-z bot deployed to preview November 28, 2023 10:59 View deployment

sreekanthpuligadda and others added 2 commits November 29, 2023 08:25

Tests/replace luke user in functional tests (#3385)

5c839a4

CVE audit update

8d38df2

hmcts-jenkins-j-to-z bot deployed to preview November 29, 2023 09:23 View deployment

Bug/cot 580 (#3383)

98d575f

* Update labels for future hearings to "FUTURE HEARING DAY" and hide all change/update links for future hearing days * Fix minor styling issue * Add units test for hearingIsInFuture * Fix linting errors

hmcts-jenkins-j-to-z bot deployed to preview November 29, 2023 10:16 View deployment

johnbenjamin-hmcts added 2 commits November 29, 2023 10:36

Revert "Bug/cot 580 (#3383)"

3c9772f

This reverts commit 98d575f.

Merge pull request #3386 from hmcts/revert-3383-bug/cot-580

654a407

Revert "Bug/cot 580"

hmcts-jenkins-j-to-z bot deployed to preview November 29, 2023 11:08 View deployment

udaydenduluri33 approved these changes Nov 29, 2023

View reviewed changes

richardhenryash approved these changes Nov 29, 2023

View reviewed changes

udaydenduluri33 merged commit 36ac810 into master Nov 29, 2023
3 checks passed

udaydenduluri33 deleted the feature/Hearings-Post-Go-Live-1.2-v3 branch November 29, 2023 11:41

Daniel-Lam suggested changes Nov 29, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hearings Post Go Live 1.2 v3 #3201

Hearings Post Go Live 1.2 v3 #3201

johnbenjamin-hmcts commented Aug 7, 2023 •

edited by udaydenduluri33

Loading

Daniel-Lam left a comment

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Daniel-Lam Nov 29, 2023

Hearings Post Go Live 1.2 v3 #3201

Hearings Post Go Live 1.2 v3 #3201

Conversation

johnbenjamin-hmcts commented Aug 7, 2023 • edited by udaydenduluri33 Loading

JIRA link (if applicable)

Change description

Daniel-Lam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnbenjamin-hmcts commented Aug 7, 2023 •

edited by udaydenduluri33

Loading