Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EUI-8736 JRD e-Links API V2 #3227

Merged
merged 35 commits into from
Oct 12, 2023
Merged

EUI-8736 JRD e-Links API V2 #3227

merged 35 commits into from
Oct 12, 2023

Conversation

johnbenjamin-hmcts
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EUI-8736

Change description

Changes to EXUI to consume new version of JRD e-Links API

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@johnbenjamin-hmcts johnbenjamin-hmcts changed the title EUI-8736 JRD e-Links API EUI-8736 JRD e-Links API V2 Aug 16, 2023
@johnbenjamin-hmcts johnbenjamin-hmcts mentioned this pull request Aug 16, 2023
Closed
DavidJayakumar
DavidJayakumar previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@DavidJayakumar DavidJayakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview August 22, 2023 09:52 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview August 24, 2023 15:36 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview August 24, 2023 16:05 Abandoned
Daniel-Lam
Daniel-Lam previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@Daniel-Lam Daniel-Lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbenjamin-hmcts - these changes look fine; approved

connorpgpmcelroy
connorpgpmcelroy previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sreekanthpuligadda sreekanthpuligadda added the enable_keep_helm enable_keep_helm label Sep 29, 2023
Mo-Lala84
Mo-Lala84 previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Mo-Lala84 Mo-Lala84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

DavidJayakumar
DavidJayakumar previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@DavidJayakumar DavidJayakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mo-Lala84
Mo-Lala84 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Mo-Lala84 Mo-Lala84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

udaydenduluri33
udaydenduluri33 reviewed Oct 12, 2023
View reviewed changes
api/workAllocation/personService.ts
for (const serviceCode of serviceCodes) {
// Judicial User search API version to be used depends upon the config entry FEATURE_JRD_E_LINKS_V2_ENABLED's value
req.headers.accept = showFeature(FEATURE_JRD_E_LINKS_V2_ENABLED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be outside loop. Minor

udaydenduluri33
udaydenduluri33 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@udaydenduluri33 udaydenduluri33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mo-Lala84 Mo-Lala84 merged commit 7a5492a into master Oct 12, 2023
3 checks passed
@Mo-Lala84 Mo-Lala84 deleted the feature/EUI-8736-JRD-e-Links-API-V2 branch October 12, 2023 09:30
andywilkinshmcts added a commit that referenced this pull request Oct 17, 2023
@andywilkinshmcts
Merge branch 'exui-937-fix-tests' into bug/cot-515-v2
5b910c3 
* exui-937-fix-tests:
  Fix minor test issues
  fix functional tests that require deleted account
  EUI-8736 JRD e-Links API V2 (#3227)

# Conflicts:
#	charts/xui-webapp/Chart.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mo-Lala84 Mo-Lala84 Mo-Lala84 approved these changes

@udaydenduluri33 udaydenduluri33 udaydenduluri33 approved these changes

@Daniel-Lam Daniel-Lam Daniel-Lam left review comments

@connorpgpmcelroy connorpgpmcelroy connorpgpmcelroy left review comments

@DavidJayakumar DavidJayakumar DavidJayakumar left review comments

Assignees
No one assigned
Labels
enable_keep_helm enable_keep_helm ns:xui prd:xui rel:xui-webapp-pr-3227
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@johnbenjamin-hmcts @Daniel-Lam @Mo-Lala84 @udaydenduluri33 @connorpgpmcelroy @DavidJayakumar @sreekanthpuligadda