Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Android accepting local imported CAs #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# dependencies
node_modules
.pnp
.pnpm-store
.pnp.js
.yarn/install-state.gz

Expand Down Expand Up @@ -52,4 +53,7 @@ data

# Idea
.idea
*.iml
*.iml

# VS-Code
.vscode
1 change: 1 addition & 0 deletions apps/mobile/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"versionCode": 11
},
"plugins": [
"./plugins/trust-local-certs.js",
"expo-router",
[
"expo-share-intent",
Expand Down
9 changes: 9 additions & 0 deletions apps/mobile/plugins/network_security_config.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
<base-config cleartextTrafficPermitted="true">
<trust-anchors>
<certificates src="system" />
<certificates src="user" />
</trust-anchors>
</base-config>
</network-security-config>
43 changes: 43 additions & 0 deletions apps/mobile/plugins/trust-local-certs.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
const { AndroidConfig, withAndroidManifest } = require("@expo/config-plugins");
const { Paths } = require("@expo/config-plugins/build/android");
const path = require("path");
const fs = require("fs");
const fsPromises = fs.promises;

const { getMainApplicationOrThrow } = AndroidConfig.Manifest;

const withTrustLocalCerts = (config) => {
return withAndroidManifest(config, async (config) => {
config.modResults = await setCustomConfigAsync(config, config.modResults);
return config;
});
};

async function setCustomConfigAsync(config, androidManifest) {
const src_file_pat = path.join(__dirname, "network_security_config.xml");
const res_file_path = path.join(
await Paths.getResourceFolderAsync(config.modRequest.projectRoot),
"xml",
"network_security_config.xml",
);

const res_dir = path.resolve(res_file_path, "..");

if (!fs.existsSync(res_dir)) {
await fsPromises.mkdir(res_dir);
}

try {
await fsPromises.copyFile(src_file_pat, res_file_path);
} catch (e) {
throw e;
}

const mainApplication = getMainApplicationOrThrow(androidManifest);
mainApplication.$["android:networkSecurityConfig"] =
"@xml/network_security_config";

return androidManifest;
}

module.exports = withTrustLocalCerts;