Remove monitor from the Set on close

holepunchto · Sep 6, 2024 · f2aa6b5 · f2aa6b5
1 parent 589bc24
commit f2aa6b5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/monitor.js b/lib/monitor.js
@@ -50,6 +50,7 @@ module.exports = class Monitor extends ReadyResource {
     this.blobs.core.off('append', this._boundOnAppend)
     this.blobs.core.off('upload', this._boundOnUpload)
     this.blobs.core.off('download', this._boundOnDownload)
+    this.drive.monitors.delete(this)
   }
 
   async _onAppend () {

diff --git a/test.js b/test.js
@@ -1615,6 +1615,15 @@ test('upload/download can be monitored', async (t) => {
   await mirror.drive.get(file)
 })
 
+test('monitor is removed from the Set on close', async (t) => {
+  const { drive } = await testenv(t.teardown)
+  const monitor = drive.monitor('/example.md')
+  await monitor.ready()
+  t.is(drive.monitors.size, 1)
+  await monitor.close()
+  t.is(drive.monitors.size, 0)
+})
+
 async function testenv (teardown) {
   const corestore = new Corestore(RAM)
   await corestore.ready()