Merge pull request #621 from fingolfin/mh/InstallValue

Avoid using InstallValue on non-plain objects
homalg-project · Dec 21, 2024 · 774f5aa · 774f5aa
2 parents cd8c5ad + a77cac3
commit 774f5aa
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/GradedModules/gap/Tate.gd b/GradedModules/gap/Tate.gd
@@ -16,14 +16,10 @@ DeclareGlobalFunction( "_Functor_TateResolution_OnGradedModules" );
 
 DeclareGlobalFunction( "_Functor_TateResolution_OnGradedMaps" );
 
-DeclareGlobalVariable( "Functor_TateResolution_ForGradedModules" );
-
 DeclareGlobalFunction( "_Functor_LinearStrandOfTateResolution_OnGradedModules" );
 
 DeclareGlobalFunction( "_Functor_LinearStrandOfTateResolution_OnGradedMaps" );
 
-DeclareGlobalVariable( "Functor_LinearStrandOfTateResolution_ForGradedModules" );
-
 
 # basic operations:
 

diff --git a/GradedModules/gap/Tate.gi b/GradedModules/gap/Tate.gi
@@ -440,7 +440,7 @@ InstallGlobalFunction( _Functor_TateResolution_OnGradedMaps, ### defines: TateRe
 
 end );
 
-InstallValue( Functor_TateResolution_ForGradedModules,
+BindGlobal( "Functor_TateResolution_ForGradedModules",
         CreateHomalgFunctor(
                 [ "name", "TateResolution" ],
                 [ "category", HOMALG_GRADED_MODULES.category ],
@@ -879,7 +879,7 @@ InstallMethod( LinearStrandOfTateResolution,
 
 end );
 
-InstallValue( Functor_LinearStrandOfTateResolution_ForGradedModules,
+BindGlobal( "Functor_LinearStrandOfTateResolution_ForGradedModules",
         CreateHomalgFunctor(
                 [ "name", "LinearStrandOfTateResolution" ],
                 [ "category", HOMALG_GRADED_MODULES.category ],

diff --git a/Modules/gap/OtherFunctors.gd b/Modules/gap/OtherFunctors.gd
@@ -17,8 +17,6 @@ DeclareGlobalFunction( "_Functor_DirectSum_OnModules" );
 
 DeclareGlobalFunction( "_Functor_DirectSum_OnMaps" );
 
-DeclareGlobalVariable( "Functor_DirectSum_for_fp_modules" );
-
 ####################################
 #
 # temporary

diff --git a/Modules/gap/OtherFunctors.gi b/Modules/gap/OtherFunctors.gi
@@ -134,7 +134,7 @@ InstallGlobalFunction( _Functor_DirectSum_OnMaps, ### defines: DirectSum (morphi
 
 end );
 
-InstallValue( Functor_DirectSum_for_fp_modules,
+BindGlobal( "Functor_DirectSum_for_fp_modules",
         CreateHomalgFunctor(
                 [ "name", "DirectSum" ],
                 [ "category", HOMALG_MODULES.category ],