Add null check on user path in mounts

[mdegat01]

Proposed change

Small fix suggested by coderabbit I forgot to put in #5438 : https://github.com/home-assistant/supervisor/pull/5438/files#r1852967759

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (which adds functionality to the supervisor)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:
• Link to cli pull request:
• Link to client library pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Ruff (ruff format supervisor tests)
• Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

• Documentation added/updated for developers.home-assistant.io
• CLI updated (if necessary)
• Client library updated (if necessary)

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in the info method to prevent issues when container_where is None.
  • ATTR_USER_PATH will now correctly return None instead of causing an error in such cases.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve a modification to the info method of the APIMounts class in the supervisor/api/mounts.py file. A conditional check was added to handle the situation where mount.container_where might be None, ensuring that ATTR_USER_PATH is assigned None in such cases instead of raising an error. No other significant changes were made to the remaining methods or the overall structure of the class.

Changes

File Path	Change Summary
supervisor/api/mounts.py	Modified the info method to include a conditional check for mount.container_where to prevent errors when it is None. ATTR_USER_PATH is set to None in this case. No changes to other methods.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7a55f58 and a4f1321.

📒 Files selected for processing (1)

• supervisor/api/mounts.py (1 hunks)

🔇 Additional comments (2)

supervisor/api/mounts.py (2)

38-40: LGTM! Clean implementation of the null check.

The conditional expression elegantly handles the case where container_where is None, preventing potential AttributeError.

---

38-40: Verify the None case handling in Mount class.

While the null check is correct, let's verify the conditions under which container_where can be None to ensure this is the expected behavior.

✅ Verification successful

The None case for container_where is expected and properly handled

The container_where property returns None when the mount's usage is not set (i.e., when self.usage is None). This is the correct behavior because:

1. The property is designed to return where a mount is made available in managed containers based on its usage type (backup, media, or share)
2. When no usage is specified (usage is None), it means the mount is not intended to be made available in managed containers
3. The code in api/mounts.py correctly handles this case by using a conditional expression to only include the path when container_where exists

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for Mount class implementation and container_where property
# to understand when it can be None

# Search for Mount class definition and container_where
ast-grep --pattern 'class Mount:
  $$$
  container_where$$$
  $$$
'

# Search for any assignments to container_where
rg -A 5 'container_where.*=' 

Length of output: 100

---

Script:

#!/bin/bash
# Let's try a different approach to find the Mount class and its usage

# Search for Mount class definition
rg -A 20 "^class Mount"

# Search for container_where in the codebase
rg "container_where"

# Search for Mount instantiation
rg "Mount\("

Length of output: 144567

---

Script:

#!/bin/bash
# Let's search for Mount class and container_where property implementation
rg -A 5 "container_where" supervisor/mounts/mount.py

# Search for any instantiation or usage of Mount class with container_where
rg -B 5 -A 5 "container_where.*=.*None" supervisor/mounts/

Length of output: 370

---

Script:

#!/bin/bash
# Let's search for the Mount class implementation and usage pattern
rg -A 20 "class Mount" supervisor/mounts/mount.py

# Search for usage property in Mount class
rg -A 5 "usage" supervisor/mounts/mount.py

# Search for where container_where is used
rg "container_where" supervisor/

Length of output: 2122

---

Script:

#!/bin/bash
# Let's get the full implementation of container_where method and its usage context
rg -B 10 -A 10 "def container_where" supervisor/mounts/mount.py

# Get the MountUsage enum definition to understand possible values
rg -A 10 "class MountUsage" supervisor/mounts/

Length of output: 1368

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.