Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Hide noisy "Unchanged files with check annotations" #3613

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Nov 2, 2024

Note

I'm not suer this fixes, but please try. And revert if this doesn't work

This PR attempts to remove noisy "Unchanged files with check annotations" in PRs.
That annotations are generated during push to main branch, but not useful since eslint-disable-next-line are ignored somehow 🤷‍♂️
image

Ref. actions/setup-node#72

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (53bd319) to head (7c1e71b).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3613    +/-   ##
========================================
  Coverage   91.70%   91.70%            
========================================
  Files         159      159            
  Lines       10145    10145            
  Branches     2975     2860   -115     
========================================
  Hits         9303     9303            
  Misses        840      840            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego marked this pull request as ready for review November 2, 2024 01:21
@yusukebe
Copy link
Member

yusukebe commented Nov 2, 2024

Hi @exoego

This is good!

but not useful since eslint-disable-next-line are ignored somehow 🤷‍♂️

Hmm. It's weird 🤷‍♂️ These should not throw the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants