Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Monitoring #669

Merged
merged 24 commits into from
Aug 12, 2024
Merged

Bug: Monitoring #669

merged 24 commits into from
Aug 12, 2024

Conversation

rajuAhmed1705
Copy link
Contributor

@rajuAhmed1705 rajuAhmed1705 commented Jul 27, 2024

scope of testing:
https://trello.com/c/yOMuCoYa

Copy link

github-actions bot commented Jul 27, 2024

Visit the preview URL for this PR (updated for commit 97e1fa4):

(expires Mon, 19 Aug 2024 10:15:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

@johannesvedder
Copy link
Contributor

Is this ready for review? @rajuAhmed1705

@rajuAhmed1705
Copy link
Contributor Author

@johannesvedder, except for the task with the intervention mismatch problem. everything is solved. I actually cannot create a study without an intervention task. So, I'm trying to figure out the other way around.

@johannesvedder
Copy link
Contributor

@johannesvedder, except for the task with the intervention mismatch problem. everything is solved. I actually cannot create a study without an intervention task. So, I'm trying to figure out the other way around.

This used to be possible in the past and we might need to re-enable this again in order to allow washout phases, as long as we have the adaptive schedule alternative. So you can revert this commit if you would like.

@ibrahimozkn
Copy link
Contributor

@johannesvedder, except for the task with the intervention mismatch problem. everything is solved. I actually cannot create a study without an intervention task. So, I'm trying to figure out the other way around.

This used to be possible in the past and we might need to re-enable this again in order to allow washout phases, as long as we have the adaptive schedule alternative. So you can revert this commit if you would like.

#671

@johannesvedder johannesvedder force-pushed the bug/monitoring branch 2 times, most recently from 25bdfc6 to 479624b Compare August 9, 2024 11:52
@johannesvedder johannesvedder marked this pull request as ready for review August 9, 2024 12:04
Copy link
Contributor

@ibrahimozkn ibrahimozkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • UI overflow when language is set to German in bar chart legends and participant details legends
  • Missing translation for ""Dropout"

image
image

Copy link
Contributor

@ibrahimozkn ibrahimozkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johannesvedder johannesvedder merged commit 670194f into dev Aug 12, 2024
11 checks passed
@johannesvedder johannesvedder deleted the bug/monitoring branch August 12, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants