Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/notifications #691

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix/notifications #691

merged 4 commits into from
Oct 2, 2024

Conversation

johannesvedder
Copy link
Contributor

@johannesvedder johannesvedder commented Oct 1, 2024 •
edited
Loading

Some more small changes to the notification debug screen and upgrade to flutter v3.24.3

@github-actions github-actions bot added dependencies Pull requests that update a dependency file app core flutter_common designer_v2 labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0be9d0c):

(expires Tue, 08 Oct 2024 13:43:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

@johannesvedder
Copy link
Contributor Author

Notifications seem to work fine for me after a day of testing. Debug screen also looks good.

ibrahimozkn
ibrahimozkn approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ibrahimozkn ibrahimozkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested scheduled notifications by manually adjusting date and time on the emulator. All notifications were received correctly.
  • Debug notification and sending debug data via email both function as expected.

✅

@ibrahimozkn ibrahimozkn merged commit 457e4aa into dev Oct 2, 2024
13 checks passed
@ibrahimozkn ibrahimozkn deleted the fix/notifications branch October 2, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimozkn ibrahimozkn ibrahimozkn approved these changes

Assignees

@johannesvedder johannesvedder

Labels
app core dependencies Pull requests that update a dependency file designer_v2 flutter_common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannesvedder @ibrahimozkn