Merge pull request #656 from hernanmd/do_not_use_author_in_P13

Use empty author in SmalltalkCIPharo13
hpi-swa · Aug 28, 2024 · 57dfe32 · 57dfe32
2 parents 781a1ba + e43b3c7
commit 57dfe32
Show file tree

Hide file tree

Showing 11 changed files with 47 additions and 1 deletion.
diff --git a/...sitory/SmalltalkCI-Core.package/SCIMetacelloIgnorePackageLoaded.class/README.md b/...sitory/SmalltalkCI-Core.package/SCIMetacelloIgnorePackageLoaded.class/README.md
diff --git a/...tory/SmalltalkCI-Core.package/SCIMetacelloIgnorePackageLoaded.class/methodProperties.json b/...tory/SmalltalkCI-Core.package/SCIMetacelloIgnorePackageLoaded.class/methodProperties.json
@@ -0,0 +1,5 @@
+{
+	"class" : {
+		 },
+	"instance" : {
+		 } }
diff --git a/repository/SmalltalkCI-Core.package/SCIMetacelloIgnorePackageLoaded.class/properties.json b/repository/SmalltalkCI-Core.package/SCIMetacelloIgnorePackageLoaded.class/properties.json
@@ -0,0 +1,14 @@
+{
+	"category" : "SmalltalkCI-Core",
+	"classinstvars" : [
+		 ],
+	"classvars" : [
+		 ],
+	"commentStamp" : "",
+	"instvars" : [
+		 ],
+	"name" : "SCIMetacelloIgnorePackageLoaded",
+	"pools" : [
+		 ],
+	"super" : "Notification",
+	"type" : "normal" }
diff --git a/...itory/SmalltalkCI-Core.package/SCIMetacelloLoadSpec.class/instance/basicLoadProjectOn..st b/...itory/SmalltalkCI-Core.package/SCIMetacelloLoadSpec.class/instance/basicLoadProjectOn..st
@@ -28,5 +28,5 @@ basicLoadProjectOn: aSmalltalkCI
 	self withExceptionHandlerDo: [ 
 		aSmalltalkCI performMetacelloLoad: [ 
 			[ metacello load: self load ]
-			on: MetacelloIgnorePackageLoaded
+			on: SCIMetacelloIgnorePackageLoaded
 			do: [ :e | e resume: self ignoreImage ] ] ]
diff --git a/...SmalltalkCI-Pharo-Core.package/IceMetacelloPharoPlatform.extension/instance/authorName.st b/...SmalltalkCI-Pharo-Core.package/IceMetacelloPharoPlatform.extension/instance/authorName.st
@@ -0,0 +1,3 @@
+*SmalltalkCI-Pharo-Core
+authorName: aString
+	"Do nothing. Kept here for SmalltalkCI compatibilitu with older/other platforms"
diff --git a/.../SmalltalkCI-Pharo-Core.package/IceMetacelloPharoPlatform.extension/methodProperties.json b/.../SmalltalkCI-Pharo-Core.package/IceMetacelloPharoPlatform.extension/methodProperties.json
@@ -0,0 +1,5 @@
+{
+	"class" : {
+		 },
+	"instance" : {
+		"authorName:" : "HernanMoralesDurand 28/8/2024 04:56" } }
diff --git a/...sitory/SmalltalkCI-Pharo-Core.package/IceMetacelloPharoPlatform.extension/properties.json b/...sitory/SmalltalkCI-Pharo-Core.package/IceMetacelloPharoPlatform.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "IceMetacelloPharoPlatform" }
diff --git a/repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/ensureAuthor.st b/repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/ensureAuthor.st
@@ -0,0 +1,3 @@
+helpers
+ensureAuthor
+	"Do nothing, as Author was removed in Pharo 13"
diff --git a/repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/getAuthor.st b/repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/getAuthor.st
@@ -0,0 +1,6 @@
+helpers
+getAuthor
+	"Answer a <String> representing an 'Author' in the image.
+	Here we answer an empty string since Author support was removed in Pharo 13"
+
+	^ ''
diff --git a/repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/setAuthor.st b/repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/setAuthor.st
@@ -0,0 +1,3 @@
+helpers
+setAuthor: anAuthor
+	"Do nothing. Author was removed in Pharo 13"
diff --git a/...I-Pharo-Tests.package/SmalltalkCIPharoTest.class/instance/testAuthorIsEmptyFromPharo13.st b/...I-Pharo-Tests.package/SmalltalkCIPharoTest.class/instance/testAuthorIsEmptyFromPharo13.st
@@ -0,0 +1,5 @@
+tests
+testAuthorIsEmptyFromPharo13
+
+	SmalltalkCI platformClass = SmalltalkCIPharo13
+		ifTrue: [ self assertEmpty: SmalltalkCI platformClass getAuthor ]