Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each time a version of Pharo is released we need to update the baseli… #595

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Each time a version of Pharo is released we need to update the baseli… #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d9a880
Each time a version of Pharo is released we need to update the baseli…
jecisc Apr 14, 2023
e285ed1
Manually fix metadatas...
jecisc Apr 14, 2023
7039fea
Merge branch 'master' into ease-pharo-management-in-baseline
jecisc Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../BaselineOfSmalltalkCI.package/BaselineOfSmalltalkCI.class/instance/pharoVersionsFrom..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
baselines
pharoVersionsFrom: aVersion

^ (aVersion to: SystemVersion current major) collect: [ :v | ('pharo' , v asString , '.x') asSymbol ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this only works in Pharo:

a MessageNotUnderstood occurred (error 2010), a Set does not understand  #'current'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in Squeak 5.1 as well. Is that error from GS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know tbh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to know if we are on Pharo, Squeak or Gemstone that works in all smalltalks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but do we really need to complicate this even more? I forgot about the semantics, but maybe the spec could just target #'pharo' instead (or #'pharoCommon'?) and then we have specific overrides for Pharo < 5 (e.g. #'pharo4.x')?

2 changes: 1 addition & 1 deletion ...malltalkCI.package/BaselineOfSmalltalkCI.class/instance/setUpPharo5AndGreaterPackages..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ baseline
setUpPharo5AndGreaterPackages: spec

spec
for: #(#'pharo5.x' #'pharo6.x' #'pharo7.x' #'pharo8.x' #'pharo9.x' #'pharo10.x' #'pharo11.x' #'pharo12.x')
for: (self pharoVersionsFrom: 5)
do: [ spec
package: 'SmalltalkCI-Core' with: [ spec includes: #('SmalltalkCI-Pharo-Core') ];
package: 'SmalltalkCI-Pharo-Core' with: [ spec requires: 'SmalltalkCI-Core' ];
Expand Down
3 changes: 2 additions & 1 deletion repository/BaselineOfSmalltalkCI.package/BaselineOfSmalltalkCI.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"setUpPharo3And4Packages:" : "GOC 10/3/2019 11:30",
"setUpGemStonePackages:" : "GOC 10/3/2019 09:36",
"setUpPharo5AndGreaterPackages:" : "GOC 10/3/2019 11:30",
"baseline:" : "GOC 10/3/2019 11:30"
"baseline:" : "CyrilFerlicot 14/04/2023 17:07",
"pharoVersionFrom:" : "CyrilFerlicot 14/04/2023 17:07"
},
"class" : { }
}
Loading