Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Multimodal Support Fixed #1147

Merged
merged 16 commits into from
May 17, 2024

Conversation

Saghen
Copy link
Collaborator

@Saghen Saghen commented May 15, 2024

Continuation of #1021 with a fix for TGI endpoints expecting multimodal inputs.

@Saghen Saghen changed the title feat: multimodal anthropic support Generic Multimodal Support Fixed May 15, 2024
Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can confirm that 8075005 does fix the issue with TGI endpoint !

@mishig25 mishig25 merged commit 97026cc into huggingface:main May 17, 2024
3 checks passed
@nsarrazin nsarrazin added the enhancement New feature or request label May 28, 2024
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* feat: multimodal anthropic support

* docs: add claude haiku and multimodal support

* feat: uploaded file detection and image conversion

* fix deps with sharp

* fix resvg deps?

* fix: image conversion, retry with files

* feat: generic image processing and size target

* docs: multimodal review comments

Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>

* docs: multimodal review comments

Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>

* feat: review comment resolution

* fix: type error on image params

* feat: add multimodal for vertex ai anthropic

* style: uploadFile timeout number

Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>

* fix: TGI endpoints expecting multimodal

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants