-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Gemini API Support #1330
Add Google Gemini API Support #1330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool contribution, @toandev95!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contrib, would be very happy to merge it! Couple things that I think need updating:
- Could we expand the doc in
google.md
a bit to explain the difference with the vertex endpoints, and explain how to use it a bit more ? - Could we make
@google/generative-ai
an optional dependency like the other providers ?
Other than that lgtm!
Thank you @nsarrazin, is there any chance you could take a look at my latest commit? Feel free to let me know if you have any additional comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for contributing
* Supports Google Gemini API * Fixed error when running svelte-check * update: from the contribution of nsarrazin
Contribute code that supports the Google Gemini API.
https://github.com/google-gemini/generative-ai-js#readme