Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sigma_last with use_flow_sigmas #10267

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

hlky
Copy link
Collaborator

@hlky hlky commented Dec 17, 2024

What does this PR do?

sigma_last is concatenated in different places across schedulers so this was missed for some schedulers with the recent use_flow_sigmas, also missed with use_exponential_sigmas and use_beta_sigmas in DPMSolverMultistepInverseScheduler.

Fixes #10266

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu @vladmandic

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@hlky
Copy link
Collaborator Author

hlky commented Dec 17, 2024

After this is merged I'll add a test that checks the length of sigmas and timesteps for each scheduler and each use_*_sigmas option so we can catch this issue in the future and I'll standardise the code for concatenating sigma_last.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hlky hlky merged commit e222246 into huggingface:main Dec 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UniPC with FlowMatch fails with index out-of-bounds
3 participants