Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmata: try to stabilize tests #1097

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 5, 2024

Solved issues and/or description of the change

Firmata test "TestProcessDigitalRead4" (run "test_platforms") failed several times in succession on the server but works locally. Try to stabilize test by increasing the timeout from 20ms to 30ms.

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review November 5, 2024 09:23
@gen2thomas gen2thomas merged commit 0d700b1 into hybridgroup:dev Nov 5, 2024
3 checks passed
@gen2thomas gen2thomas deleted the fix/stabilize_firmata_test branch November 5, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant