typo #65
Open
typo #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…async hard dependency
…trol over core.async hard dependency"
The use case is filled by `dom2/on!`, i.e. for running local (synchronous) side effects.
this fixes todomvc-composed observe consumer not ready error In UIs we typically care about latest events and it's fine to drop unprocessed events, so this change is safe. Note: relieving in e/for-event would work too, but relieving the DOM events is a tighter fix and allows e/for-event users to pick backpressure strategy themselves (e.g. buffer).
in some undefined cases the controls get 2 focus events in quick succession. With the previous event handling strategies this went unnoticed (the event got superseded). We now use e/do-event-pending to discard duplicate focus events
the core.async helpers were moved to a new ns in 739331f
…also remove dom/sample (unused, not useful) dom/sample does not subsume enough use cases to be useful
… unlikely due to low-level api)
datomic-m setup is broken with this addition, commented out from startup, fix once needed
Local edits are stored as if on a branch. Clicking commit merges changes back into the global transactor. Clicking discard throws the local changes away.
With multiple editors double-clicking on 1 todo item would open the item for editing in all editors. This fix opens the item for editing only in the 1 editor we clicked it. The multi-editor setup was broken anyway because - focus could end up in the wrong editor - edits weren't propagating to other editors
We expect to have users of ui4/button and don't want to force inline styles on them.
Larger stack size was required before IC. Not anymore.
Electric Jetty and HTTPKit adapters are now based on latest Ring. Latest Ring (1.11+) support websockets out of the box. It is now simpler to: - integrate electric into existing ring apps, - extend the electric adapter over new HTTP servers. Breaking changes: - `hyperfiddle.electric-jetty-adapter` has been replaced by the simpler, generic `hyperfiddle.electric-ring-adapter`. - The API is simpler, smaller, but is not retrocompatible. - Code depending on `electric-jetty-adapter` must be updated. - `hyperfiddle.electric-httpkit-adapter` is now based on `electric-ring-adapter` and exposes the same API. The two namespaces are equivalent, they only differ on the underlying HTTP server. - Note latest ring-jetty depends on Jetty 11, which requires Java 11+ - Electric can run with Jetty 9 and Java 8 - We found no use case for Java 8 retro compatibility so far - If you need Jetty9 / Java 8 compat, see [electric-server-java-9-jetty-9](https://github.com/hyperfiddle/electric/blob/cc55772f18bc46373f131e092fc20055c8062b59/src-docs/electric_server_java8_jetty9.clj) and [electric-jetty-adapter](https://github.com/hyperfiddle/electric/blob/cc55772f18bc46373f131e092fc20055c8062b59/src/hyperfiddle/electric_jetty_adapter.clj) How to migrate: - Look at the integration for: - Jetty: [Electric jetty integration](https://github.com/hyperfiddle/electric-fiddle/blob/01b49391e38d2684a7cbf7f82fa58da503af5be8/src/electric_fiddle/server_jetty.clj) - HTTPKit [Electric httpkit integration](https://github.com/hyperfiddle/electric-fiddle/blob/01b49391e38d2684a7cbf7f82fa58da503af5be8/src/electric_fiddle/server_httpkit.clj) - update your ring middlewares accordingly
Clicking two links fast (a few milliseconds between two clicks) would trigger a hard navigation instead of being intercepted by the router and triggering a soft nav.
dustingetz
force-pushed
the
master
branch
3 times, most recently
from
6c6c253
to
7e3400f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.