-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clj-kondo config for e/for-by #69
Add clj-kondo config for e/for-by #69
Commits on May 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fa5218a - Browse repository at this point
Copy the full SHA fa5218aView commit details -
electric-dom: remove dom/Event (breaking; however external callers is…
… unlikely due to low-level api)
Configuration menu - View commit details
-
Copy full SHA for a65ed41 - Browse repository at this point
Copy the full SHA a65ed41View commit details
Commits on May 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4e16194 - Browse repository at this point
Copy the full SHA 4e16194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dbbf57 - Browse repository at this point
Copy the full SHA 9dbbf57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c2729c - Browse repository at this point
Copy the full SHA 3c2729cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b546526 - Browse repository at this point
Copy the full SHA b546526View commit details
Commits on May 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6b51947 - Browse repository at this point
Copy the full SHA 6b51947View commit details -
add datomic peer dependency for demos
datomic-m setup is broken with this addition, commented out from startup, fix once needed
Configuration menu - View commit details
-
Copy full SHA for feef06f - Browse repository at this point
Copy the full SHA feef06fView commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 15fb021 - Browse repository at this point
Copy the full SHA 15fb021View commit details
Commits on Jun 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 63045aa - Browse repository at this point
Copy the full SHA 63045aaView commit details
Commits on Jun 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4e750a4 - Browse repository at this point
Copy the full SHA 4e750a4View commit details -
add todomvc branched demo (with staging area)
Local edits are stored as if on a branch. Clicking commit merges changes back into the global transactor. Clicking discard throws the local changes away.
Configuration menu - View commit details
-
Copy full SHA for db00a48 - Browse repository at this point
Copy the full SHA db00a48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83ff272 - Browse repository at this point
Copy the full SHA 83ff272View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f6f9b - Browse repository at this point
Copy the full SHA f2f6f9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fec7fa3 - Browse repository at this point
Copy the full SHA fec7fa3View commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for defd452 - Browse repository at this point
Copy the full SHA defd452View commit details
Commits on Jun 7, 2023
-
fix todomvc-composed regression by editing input in 1 editor only
With multiple editors double-clicking on 1 todo item would open the item for editing in all editors. This fix opens the item for editing only in the 1 editor we clicked it. The multi-editor setup was broken anyway because - focus could end up in the wrong editor - edits weren't propagating to other editors
Configuration menu - View commit details
-
Copy full SHA for fef8b66 - Browse repository at this point
Copy the full SHA fef8b66View commit details
Commits on Jun 9, 2023
-
move ui4/button colors out into ui4/button-colored
We expect to have users of ui4/button and don't want to force inline styles on them.
Configuration menu - View commit details
-
Copy full SHA for eec2f3d - Browse repository at this point
Copy the full SHA eec2f3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff9b382 - Browse repository at this point
Copy the full SHA ff9b382View commit details -
Configuration menu - View commit details
-
Copy full SHA for 295a4b3 - Browse repository at this point
Copy the full SHA 295a4b3View commit details
Commits on Jun 12, 2023
-
Our new Datomic demos reading off the tx queue create a singleton reader of the queue since multiple readers steal values off the queue (it is not pub/sub). This singleton is a separate thread and we need to make sure it doesn't block the JVM from shutting down (i.e. make them daemon). The TodoMVC demos now use daemon threads. The advanced todolist demos are removed from the requires since - they need updating to use the daemon thread pattern - are not linked to anyway since they are in early prototype stage
Configuration menu - View commit details
-
Copy full SHA for b28b421 - Browse repository at this point
Copy the full SHA b28b421View commit details
Commits on Jun 13, 2023
-
introduce e/offload-latest to solve pending-over-rendering and cycles…
… in callbacks instead of (e/offload #(db-query a b c)) now write (e/offload-latest db-query a b c) differences: - takes *electric* varargs instead of clojure thunk - doesn't return intermediate Pendings. This fixes over-rendering and cycles in callbacks because work-skipping will correctly kick in. Might not be the final solution to this problem space, but a fine solution for now as it fixes all user concerns and doesn't need e/snapshot.
Configuration menu - View commit details
-
Copy full SHA for 7efab97 - Browse repository at this point
Copy the full SHA 7efab97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54c61bd - Browse repository at this point
Copy the full SHA 54c61bdView commit details
Commits on Jun 14, 2023
-
document weird behavior in client/server transfer where we seem to see an old value. Not in all cases though, 3 out of 4 patterns.
Configuration menu - View commit details
-
Copy full SHA for 5d2ceeb - Browse repository at this point
Copy the full SHA 5d2ceebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 585dd24 - Browse repository at this point
Copy the full SHA 585dd24View commit details
Commits on Jun 19, 2023
-
Fix dom2/parse-class failing to flatten classes - add tests
``` ;; Was ok: (parse-class "a b") := ["a" "b"] (parse-class ["a" "b"]) := ["a" "b"] ;; Was failing - now fixed (parse-class ["a b" "c"]) := ["a b" "c"] ; "a b" is not a valid dom class (contains a space) ```
Configuration menu - View commit details
-
Copy full SHA for ef04365 - Browse repository at this point
Copy the full SHA ef04365View commit details -
Fix dom2/props improperly setting some DOM attributes
For cross browser compat, some DOM attributes should always be set using `setAttribute`, not by their corresponding property¹. E.g. ```javascript node.setAttribute("colspan", 2); // no browser quirks node.colSpan = 2; // potential browser quirks ``` The Google Closure Library lists these attributes in `goog.dom.DIRECT_ATTRIBUTE_MAP_`². We respect this requirement and implemented a similar logic to the one in `goog.dom`, which given a `colspan` property will call `setAttribute("colSpan")`. We later introduced a bug when we added SVG support which requires the newer `setAttributeNS` method. `setAttributeNS` differentiates between `colspan` vs `colSpan`, where the older `setAttribute` doesn't. Thus, not setting the right attribute. ¹: https://github.com/google/closure-library/blob/c31b49fecdbea74df02049358460deda64bff244/closure/goog/dom/dom.js#L519 ²: ```javascript /** * Map of attributes that should be set using * element.setAttribute(key, val) instead of element[key] = val. Used * by goog.dom.setProperties. * * @Private {!Object<string, string>} * @const */ goog.dom.DIRECT_ATTRIBUTE_MAP_ = { 'cellpadding': 'cellPadding', 'cellspacing': 'cellSpacing', 'colspan': 'colSpan', 'frameborder': 'frameBorder', 'height': 'height', 'maxlength': 'maxLength', 'nonce': 'nonce', 'role': 'role', 'rowspan': 'rowSpan', 'type': 'type', 'usemap': 'useMap', 'valign': 'vAlign', 'width': 'width' }; ```
Configuration menu - View commit details
-
Copy full SHA for f2ea63b - Browse repository at this point
Copy the full SHA f2ea63bView commit details -
- allows keywords and symbols - returns only unique values - allows `nil` punning - fails fast on other values
Configuration menu - View commit details
-
Copy full SHA for 4428eac - Browse repository at this point
Copy the full SHA 4428eacView commit details -
Configuration menu - View commit details
-
Copy full SHA for e999671 - Browse repository at this point
Copy the full SHA e999671View commit details -
Configuration menu - View commit details
-
Copy full SHA for cab3259 - Browse repository at this point
Copy the full SHA cab3259View commit details
Commits on Jun 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 57f4a3d - Browse repository at this point
Copy the full SHA 57f4a3dView commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 61a42a5 - Browse repository at this point
Copy the full SHA 61a42a5View commit details -
3
Configuration menu - View commit details
-
Copy full SHA for 01d7c97 - Browse repository at this point
Copy the full SHA 01d7c97View commit details -
fix warnings when calling goog modules in electric
Add tests that blow up CI in case of regression
Configuration menu - View commit details
-
Copy full SHA for f657236 - Browse repository at this point
Copy the full SHA f657236View commit details
Commits on Jun 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 17e49cd - Browse repository at this point
Copy the full SHA 17e49cdView commit details
Commits on Jun 27, 2023
-
fix js/alert-like calls relying on js this=Window
By the time they ran they were running in a different context where `this` wasn't the Window object. As a fix we compile the call as interop, where the precondition holds.
Configuration menu - View commit details
-
Copy full SHA for 6835905 - Browse repository at this point
Copy the full SHA 6835905View commit details -
Configuration menu - View commit details
-
Copy full SHA for b14a572 - Browse repository at this point
Copy the full SHA b14a572View commit details
Commits on Jun 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 97dea86 - Browse repository at this point
Copy the full SHA 97dea86View commit details -
Implement WS heartbeat at the message level for HTTPKit compat.
Server used to send PING frames to client, which is more correct. We want Jetty and HTTPKit compat. Jetty supports PING/PONG, not HTTPKit. Server is now passive, and keeps the connection alive for some times after the last received message. Client periodically sends the message "HEARTBEAT". Server detects "HEARTBEAT" and discard it.
Configuration menu - View commit details
-
Copy full SHA for 6008d18 - Browse repository at this point
Copy the full SHA 6008d18View commit details
Commits on Jun 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4c1eb9d - Browse repository at this point
Copy the full SHA 4c1eb9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f683ad - Browse repository at this point
Copy the full SHA 1f683adView commit details
Commits on Jul 3, 2023
-
Previously threw exception for empty string or string with leading or trailing spaces.
Configuration menu - View commit details
-
Copy full SHA for 32a6181 - Browse repository at this point
Copy the full SHA 32a6181View commit details -
Configuration menu - View commit details
-
Copy full SHA for 201838e - Browse repository at this point
Copy the full SHA 201838eView commit details
Commits on Jul 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1d048c1 - Browse repository at this point
Copy the full SHA 1d048c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2057e3a - Browse repository at this point
Copy the full SHA 2057e3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17d03d7 - Browse repository at this point
Copy the full SHA 17d03d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 196ebe9 - Browse repository at this point
Copy the full SHA 196ebe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b403d6c - Browse repository at this point
Copy the full SHA b403d6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 215b9e4 - Browse repository at this point
Copy the full SHA 215b9e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e239aaf - Browse repository at this point
Copy the full SHA e239aafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9833e05 - Browse repository at this point
Copy the full SHA 9833e05View commit details
Commits on Jul 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3240013 - Browse repository at this point
Copy the full SHA 3240013View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed95e8 - Browse repository at this point
Copy the full SHA 8ed95e8View commit details
Commits on Jul 12, 2023
-
Uncaugh server side error sent to default logger
Used to be printed with println. We want uncaugh errors (bubbling to the reactor root) to go to the default logger.
Configuration menu - View commit details
-
Copy full SHA for fe402e4 - Browse repository at this point
Copy the full SHA fe402e4View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fdacafe - Browse repository at this point
Copy the full SHA fdacafeView commit details
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 76e5840 - Browse repository at this point
Copy the full SHA 76e5840View commit details -
Configuration menu - View commit details
-
Copy full SHA for 738b8c9 - Browse repository at this point
Copy the full SHA 738b8c9View commit details
Commits on Jul 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9456157 - Browse repository at this point
Copy the full SHA 9456157View commit details -
Fix unsafe "popstate" monitoring in our HTML5 history impl
We don’t want foreign code to break our history impl by messing with HTML5 browser history state.
Configuration menu - View commit details
-
Copy full SHA for 2145a2f - Browse repository at this point
Copy the full SHA 2145a2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e205ed1 - Browse repository at this point
Copy the full SHA e205ed1View commit details -
Add history OnNavigate to intercept internal link navigation
Default action is to navigate with the router in scope. When integrating in an existing app with an existing router (e.g. fulcro app), we want to redirect navigation to the existing router.
Configuration menu - View commit details
-
Copy full SHA for 5b92f83 - Browse repository at this point
Copy the full SHA 5b92f83View commit details
Commits on Jul 28, 2023
-
Clients kicked out by server on heartbeat timeout will try to reconnect
Clients were not reconnecting on server heartbeat timeout. Users would see a blank page after waking up their computer from sleep or after switching to an old browser tab. On timeout, the server now closes the connection with code 1013 "Try again later". Client will try again.
2Configuration menu - View commit details
-
Copy full SHA for 0e53fae - Browse repository at this point
Copy the full SHA 0e53faeView commit details
Commits on Jul 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 47b4f3d - Browse repository at this point
Copy the full SHA 47b4f3dView commit details
Commits on Aug 1, 2023
-
Print ex-data on reactor crash
REPL usu. print ex-data, but not prod log systems. Putting ex-data at the end of the log message ensures it will be visible.
Configuration menu - View commit details
-
Copy full SHA for 66d5baa - Browse repository at this point
Copy the full SHA 66d5baaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f74a488 - Browse repository at this point
Copy the full SHA f74a488View commit details -
Configuration menu - View commit details
-
Copy full SHA for 447d9a6 - Browse repository at this point
Copy the full SHA 447d9a6View commit details
Commits on Aug 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4cce0b7 - Browse repository at this point
Copy the full SHA 4cce0b7View commit details
Commits on Aug 5, 2023
-
Add :style/indent meta to macros with body parameters.
This metadata is used by CIDER, clojure-lsp, and possibly other editors to support proper indentation of macros.
Configuration menu - View commit details
-
Copy full SHA for e6faa1e - Browse repository at this point
Copy the full SHA e6faa1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e8062 - Browse repository at this point
Copy the full SHA a4e8062View commit details -
datomic test fixtures restored, consolidate and export under contrib …
…ns for libraries. todo lift all datomic demos/contrib into electric-fiddle
Configuration menu - View commit details
-
Copy full SHA for d32267e - Browse repository at this point
Copy the full SHA d32267eView commit details -
test fixtures: teeshirt-orders demo was already lifted to hfql, the c…
…ontent matches, delete dead code
Configuration menu - View commit details
-
Copy full SHA for 093b274 - Browse repository at this point
Copy the full SHA 093b274View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea42bae - Browse repository at this point
Copy the full SHA ea42baeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ef39b - Browse repository at this point
Copy the full SHA 00ef39bView commit details
Commits on Aug 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 89c858e - Browse repository at this point
Copy the full SHA 89c858eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dc4f9a - Browse repository at this point
Copy the full SHA 2dc4f9aView commit details
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6104ea6 - Browse repository at this point
Copy the full SHA 6104ea6View commit details
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 173d3b0 - Browse repository at this point
Copy the full SHA 173d3b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fbd626 - Browse repository at this point
Copy the full SHA 9fbd626View commit details -
Revert "add client<->server metadata transfer"
This reverts commit 3240013. We don't see a good use case right now
Configuration menu - View commit details
-
Copy full SHA for c9f352a - Browse repository at this point
Copy the full SHA c9f352aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbbd147 - Browse repository at this point
Copy the full SHA dbbd147View commit details -
Configuration menu - View commit details
-
Copy full SHA for 239d15c - Browse repository at this point
Copy the full SHA 239d15cView commit details
Commits on Aug 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 005c0bb - Browse repository at this point
Copy the full SHA 005c0bbView commit details
Commits on Aug 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 280ae02 - Browse repository at this point
Copy the full SHA 280ae02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98df877 - Browse repository at this point
Copy the full SHA 98df877View commit details -
Fix inference warning when ^js tag is on lexical binding
Record lexical scope binding meta (e.g. ^:tag 'js) in env, for better interop code gen.
Configuration menu - View commit details
-
Copy full SHA for 7bf3cda - Browse repository at this point
Copy the full SHA 7bf3cdaView commit details -
Revert "history: fix ^js warnings"
This reverts commit a4e8062.
Configuration menu - View commit details
-
Copy full SHA for 46c0eb4 - Browse repository at this point
Copy the full SHA 46c0eb4View commit details -
Fix cljs interop inference warning on HTML5History type
Was tagged `^js` but is not a plain js object.
Configuration menu - View commit details
-
Copy full SHA for f38a285 - Browse repository at this point
Copy the full SHA f38a285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37ddce3 - Browse repository at this point
Copy the full SHA 37ddce3View commit details -
improve type inference on interop method calls
The originating object's metadata is passed into the method call's fn
Configuration menu - View commit details
-
Copy full SHA for e69af7c - Browse repository at this point
Copy the full SHA e69af7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a63292 - Browse repository at this point
Copy the full SHA 0a63292View commit details
Commits on Aug 17, 2023
-
fix clj class type hints debug metadata breaking cljs compilation
fixes core.match usage, which can include a clojure.lang.IPersistentVector class tag in certain patterns. This class object ended up in the debug metadata and cljs could not serialize it. WARN: keeping arbitrary metadata is dangerous as there might be other non-serializable values. We fixed this 1 edge case and left the rest as-is for now, but a more general solution might be neede in the future.
Configuration menu - View commit details
-
Copy full SHA for 915b5a4 - Browse repository at this point
Copy the full SHA 915b5a4View commit details
Commits on Aug 18, 2023
-
allow ns objects in server compiled code
The namespace object breaks cljs build. fixes clojure.tools.logging
2Configuration menu - View commit details
-
Copy full SHA for a03b341 - Browse repository at this point
Copy the full SHA a03b341View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aeab8f - Browse repository at this point
Copy the full SHA 7aeab8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 783f204 - Browse repository at this point
Copy the full SHA 783f204View commit details -
Configuration menu - View commit details
-
Copy full SHA for 567cb76 - Browse repository at this point
Copy the full SHA 567cb76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ded53d - Browse repository at this point
Copy the full SHA 2ded53dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d246d71 - Browse repository at this point
Copy the full SHA d246d71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1966a2b - Browse repository at this point
Copy the full SHA 1966a2bView commit details -
clj-doc: fix(?) with quick workaround by marking contrib.missionary-c…
…ore-async as :skip-doc
Configuration menu - View commit details
-
Copy full SHA for a48273b - Browse repository at this point
Copy the full SHA a48273bView commit details
Commits on Aug 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a10a3b9 - Browse repository at this point
Copy the full SHA a10a3b9View commit details
Commits on Aug 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5b0e797 - Browse repository at this point
Copy the full SHA 5b0e797View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96e5c0a - Browse repository at this point
Copy the full SHA 96e5c0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecd018d - Browse repository at this point
Copy the full SHA ecd018dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 178935b - Browse repository at this point
Copy the full SHA 178935bView commit details
Commits on Aug 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for df72ccb - Browse repository at this point
Copy the full SHA df72ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 702f2e9 - Browse repository at this point
Copy the full SHA 702f2e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 164a13d - Browse repository at this point
Copy the full SHA 164a13dView commit details
Commits on Aug 24, 2023
-
fix [goog.string :refer (format)] -like refers
shadow-cljs does post-ns-anlysis and expects an empty compiler cache, but we filled it manually to fix some inferecne warnings. Therefore we turn this post-check off.
Configuration menu - View commit details
-
Copy full SHA for 22937f7 - Browse repository at this point
Copy the full SHA 22937f7View commit details -
contrib.datomic-m: use logger to log Datomic detected version on star…
…tup, not println
Configuration menu - View commit details
-
Copy full SHA for 9ee2d8c - Browse repository at this point
Copy the full SHA 9ee2d8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fb4aa8 - Browse repository at this point
Copy the full SHA 7fb4aa8View commit details
Commits on Aug 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 57d02b3 - Browse repository at this point
Copy the full SHA 57d02b3View commit details
Commits on Aug 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 537e601 - Browse repository at this point
Copy the full SHA 537e601View commit details
Commits on Aug 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 55a594a - Browse repository at this point
Copy the full SHA 55a594aView commit details
Commits on Aug 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6bc8f00 - Browse repository at this point
Copy the full SHA 6bc8f00View commit details -
Fix history not intercepting link clicks when <a> is not the direct t…
…arget E.g.: <a href=""><button>Button Link</button></a> was not working, because the click target is the button, not the link itself. Checking for `hyperfiddle_history_route` is enough do detect a navigation intent.
Configuration menu - View commit details
-
Copy full SHA for 7bf3c2f - Browse repository at this point
Copy the full SHA 7bf3c2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9065f6 - Browse repository at this point
Copy the full SHA b9065f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 754268d - Browse repository at this point
Copy the full SHA 754268dView commit details
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ef937e2 - Browse repository at this point
Copy the full SHA ef937e2View commit details
Commits on Sep 4, 2023
-
Drop contrib.ordered-map custom impl
We believe this custom impl was originally needed for clj and cljs compat. Our use case is now covered by `org.flatland/ordered` since 1.15.10. We don’t see value into maintaining a custom impl anymore. https://github.com/clj-commons/ordered
Configuration menu - View commit details
-
Copy full SHA for 983544c - Browse repository at this point
Copy the full SHA 983544cView commit details
Commits on Sep 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b294768 - Browse repository at this point
Copy the full SHA b294768View commit details
Commits on Sep 13, 2023
-
Smaller e/on-unmount macroexpansion
Every electric-dom/element (every div, span, etc…) produces an `on-unmount`. `on-unmount` macro was expanding to an m/observe and a closure in Electric land. Using `partial` produces a smaller program. Saving us a small cost at scale.
Configuration menu - View commit details
-
Copy full SHA for 5d95bdf - Browse repository at this point
Copy the full SHA 5d95bdfView commit details -
Fix
Uncaught InternalError: too much recursion
Introduce the low-level `e/fn*` for smaller generated programs. Giving us large leeway until we reach the definitive solution: incremental compilation. Every electric-dom element and every `e/for` were introducing an `e/fn`, which macroexpands to a LOT of code: - argument binding (one clojurescript let per arg, so one nested js function per let) - arity check (conditional and exception throwing) - self-recursion support (one self binding -> one cljs let -> one nested js function) - multi-arities dispatch (case dispatch, apply call (including a case dispatch)) - variadic args Today, each e/fn compiles to *at least* 5 nested js functions (without :advanced compilation). So the js program nesting is at least 5×UI depth. It was measured¹ Chrome js parser (c++ impl, called by js/eval or document.write("<script> … </script>")) chokes on js programs with ~250 levels of function nesting. Before this change, a UI of depth 50 (50×5=250) would exceed the threshold. This change reduces nesting by a factor of at least 5, allowing static UIs of depth 250+. ¹: Measurement method: - compile failing electric program under :optimization :simple - pretty print output js file with `uglifyjs program.js --pretty --output program.pretty.js` - split `program.pretty.js` into lines - count spaces in front of line (/^\s+/) - divide by 4 – because one indentation level is 4 spaces - sort descending
Configuration menu - View commit details
-
Copy full SHA for f130ffd - Browse repository at this point
Copy the full SHA f130ffdView commit details
Commits on Sep 14, 2023
-
jetty adapter: bump mailbox on byte payload
We don't send bytes today so this didn't cause issues
Configuration menu - View commit details
-
Copy full SHA for 219a987 - Browse repository at this point
Copy the full SHA 219a987View commit details -
Before we added HTTPKit support the server sent PING frames to the client. The client responded with a PONG. If the connection was idle the server closed it. HTTPKit doesn't have websocket PING support [1]. To support and unify with Jetty we changed heartbeats - now the client sent a special HEARTBEAT message to the server periodically [2]. This resulted in a regression. Chrome throttles a hidden tab's timers after 5 minutes [3]. They tick in a batch once a minute. We set the max allowed idle time for a connection to 59 seconds since we deploy to fly.io which kills every TCP connection idle for over 1 minute [4]. The result - in Chrome the connection dies and reconnects in a loop. This commit overcomes all of the above limitations. The server takes back the initiative and sends a HEARTBEAT message to every client. The client sends a HEARTBEAT message back to the server. This way - we don't rely on websocket PINGs (since HTTPKit doesn't have them) - we don't get throttled in Chrome (since we now rely on server timers) - we fit into Fly's 1 minute limit [1] http-kit/http-kit#350 [2] hyperfiddle@6008d18 [3] https://developer.chrome.com/blog/timer-throttling-in-chrome-88/ [4] https://community.fly.io/t/app-connection-timeout/5369
Configuration menu - View commit details
-
Copy full SHA for 5a3799b - Browse repository at this point
Copy the full SHA 5a3799bView commit details
Commits on Sep 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 046e183 - Browse repository at this point
Copy the full SHA 046e183View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2faf3a9 - Browse repository at this point
Copy the full SHA 2faf3a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46f9a0d - Browse repository at this point
Copy the full SHA 46f9a0dView commit details
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0842e64 - Browse repository at this point
Copy the full SHA 0842e64View commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1f1c61a - Browse repository at this point
Copy the full SHA 1f1c61aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c910935 - Browse repository at this point
Copy the full SHA c910935View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b8452 - Browse repository at this point
Copy the full SHA 36b8452View commit details -
Optimize electric-dom2 macroexpansion size
`dom/props` and `dom/style` will now only touch CSS properties that changed, because it is the idiomatic thing to do. At the cost of introducing one e/for per `dom/style` Before, we were setting all CSS properties for a node when any of them changed. It was not a perf problem as browsers won’t trigger a repaint/layout if a property value has not changed.
Configuration menu - View commit details
-
Copy full SHA for 641a557 - Browse repository at this point
Copy the full SHA 641a557View commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7170088 - Browse repository at this point
Copy the full SHA 7170088View commit details
Commits on Sep 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e4be2eb - Browse repository at this point
Copy the full SHA e4be2ebView commit details
Commits on Oct 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5ae2c54 - Browse repository at this point
Copy the full SHA 5ae2c54View commit details -
Configuration menu - View commit details
-
Copy full SHA for da5cadd - Browse repository at this point
Copy the full SHA da5caddView commit details -
Optimize call js globals with the correct
this
contextPrevious impl was emitting an IIFE the Google Closure Compiler could not inline. This change moves the `this` binding from compile time to runtime. The cost is lower, because the emitted code is smaller and the `this` binding happens on program initialization, before electric runs. Example of calling a js global with the wrong `this` context: `(apply js/alert ["hello"])` would translate to alert.call(null, ["hello"]), whereas the correct form should be `alert.call(window, ["hello"])`
Configuration menu - View commit details
-
Copy full SHA for 65bd375 - Browse repository at this point
Copy the full SHA 65bd375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41e0b49 - Browse repository at this point
Copy the full SHA 41e0b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 030be74 - Browse repository at this point
Copy the full SHA 030be74View commit details -
Fix js field access generating invalid js fn argument symbol
Electric compiled `(.-field js/three.nesting.level)` to the invalid: `function($three$nesting.level){ … }`. It now produces `function($three$nesting_level){…}`. `(fn [a.b])` is invalid in clj and cljs because `a.b` is an illegal field name. Cljs compiles it to `function(a.b){}` which is also invalid javascript.
Configuration menu - View commit details
-
Copy full SHA for f32f46e - Browse repository at this point
Copy the full SHA f32f46eView commit details
Commits on Oct 6, 2023
-
Fix js functions equality when accessed from global scope
Commit 65bd375 broke equality between global js fns and classes: e.g. `(= js/Error js/Error) is true in js and cljs but was false in Electric.
Configuration menu - View commit details
-
Copy full SHA for 67d05d2 - Browse repository at this point
Copy the full SHA 67d05d2View commit details
Commits on Oct 18, 2023
-
Fix link target attribute ignored when clicking on a link's child ele…
…ment E.g. `<a target="_blank"><button> Click me! </button></a>` The button is the click target so the "target" attribute was incorrectly looked up on the event target, not the link itself.
Configuration menu - View commit details
-
Copy full SHA for cc55772 - Browse repository at this point
Copy the full SHA cc55772View commit details
Commits on Oct 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ad59615 - Browse repository at this point
Copy the full SHA ad59615View commit details
Commits on Oct 30, 2023
-
Fix commonjs modules references from electric
`react-dom` failed to resolve in: ``` (require '["react-dom/client" :as react-dom]) (e/defn [] (react-dom/createRoot dom/node)) ``` Reason was Shadow-cljs rewrites references to commonjs modules as: `react-dom/createRoot` -> `js/modules$react_dom$client$.createRoot`. `react-dom` is therefore not a valid cljs ns after shadow rewrite. Our code was macroexpanding to `react-dom/createRoot, not to the rewritten form. No test added. Judged low ROI. Adding proper tests would mean creating an local (i.e non deployed) npm package with two levels of nesting. Ticketed.
Configuration menu - View commit details
-
Copy full SHA for 030da63 - Browse repository at this point
Copy the full SHA 030da63View commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 31e762f - Browse repository at this point
Copy the full SHA 31e762fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d51d0 - Browse repository at this point
Copy the full SHA 96d51d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 814fba8 - Browse repository at this point
Copy the full SHA 814fba8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d04e474 - Browse repository at this point
Copy the full SHA d04e474View commit details
Commits on Nov 16, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for b6d9865 - Browse repository at this point
Copy the full SHA b6d9865View commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 47f9ce3 - Browse repository at this point
Copy the full SHA 47f9ce3View commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6dff962 - Browse repository at this point
Copy the full SHA 6dff962View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c42f82 - Browse repository at this point
Copy the full SHA 4c42f82View commit details -
IC - Fix heroicons icons breaking electric runtime
These macros where resolved as functions, and failed to resolve at runtime.
Configuration menu - View commit details
-
Copy full SHA for 9a2aade - Browse repository at this point
Copy the full SHA 9a2aadeView commit details -
Fix contrib.walk on values with meta but without support for with-meta
`(prewalk identity *ns*)` was failing because while Namespace instances have meta (IMeta) they don’t support with-meta (IObj). i.e. Namespace instances’ metas can only be mutated in place.
Configuration menu - View commit details
-
Copy full SHA for 6823ae6 - Browse repository at this point
Copy the full SHA 6823ae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 247b9e7 - Browse repository at this point
Copy the full SHA 247b9e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c51454c - Browse repository at this point
Copy the full SHA c51454cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 315db0e - Browse repository at this point
Copy the full SHA 315db0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba618d1 - Browse repository at this point
Copy the full SHA ba618d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89a03b2 - Browse repository at this point
Copy the full SHA 89a03b2View commit details -
load current
*ns*
when expanding clj code- cljs compilation may trigger before clj compilation (cljc ns without self require-macros compiled by cljs/shadow) - macros (even cc/let) won't resolve (ns isn't loaded) - therefore we load it before trying to expand
Configuration menu - View commit details
-
Copy full SHA for d6e24b2 - Browse repository at this point
Copy the full SHA d6e24b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ce341 - Browse repository at this point
Copy the full SHA 12ce341View commit details -
Configuration menu - View commit details
-
Copy full SHA for a768ac7 - Browse repository at this point
Copy the full SHA a768ac7View commit details -
shadow dev hook: don't reload on first run
The first run is clean and the clj side will load. It's the subsequent runs where we need to ensure a reload.
Configuration menu - View commit details
-
Copy full SHA for 64822a0 - Browse repository at this point
Copy the full SHA 64822a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b00810 - Browse repository at this point
Copy the full SHA 7b00810View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cc43ad - Browse repository at this point
Copy the full SHA 9cc43adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e286b4 - Browse repository at this point
Copy the full SHA 2e286b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69423bb - Browse repository at this point
Copy the full SHA 69423bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c8a855 - Browse repository at this point
Copy the full SHA 3c8a855View commit details -
pre-compile e/apply branching code
This reduces code size on all e/apply call sites
Configuration menu - View commit details
-
Copy full SHA for 593a5c3 - Browse repository at this point
Copy the full SHA 593a5c3View commit details -
don't try to clj expand in cljs block
This is harmful now, e.g. it loads the test namespace clj side even when not needed. The cljs expander code should take care of the expansion.
Configuration menu - View commit details
-
Copy full SHA for 608a4b2 - Browse repository at this point
Copy the full SHA 608a4b2View commit details -
the `tests` macro wrapping `rcf/tests` doesn't work correctly in node/browser tests, it only reports if the last test in the file failed.
Configuration menu - View commit details
-
Copy full SHA for 16885ca - Browse repository at this point
Copy the full SHA 16885caView commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d0d38e7 - Browse repository at this point
Copy the full SHA d0d38e7View commit details -
There's a single branch that handles varargs dynamically (at runtime).
Configuration menu - View commit details
-
Copy full SHA for 9037712 - Browse repository at this point
Copy the full SHA 9037712View commit details -
check for :dev mode in shadow hook
thanks for the suggestion @eneroth
Configuration menu - View commit details
-
Copy full SHA for a6f0283 - Browse repository at this point
Copy the full SHA a6f0283View commit details
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3a8255e - Browse repository at this point
Copy the full SHA 3a8255eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7ca42d - Browse repository at this point
Copy the full SHA b7ca42dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7cf2a5 - Browse repository at this point
Copy the full SHA f7cf2a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fab0b4f - Browse repository at this point
Copy the full SHA fab0b4fView commit details -
contrib.assert: easy keyword equality checks
# Conflicts: # src/contrib/assert.cljc
Configuration menu - View commit details
-
Copy full SHA for 789372e - Browse repository at this point
Copy the full SHA 789372eView commit details -
lift electric-demo to electric-fiddle; leave electric-ui css resource…
…s behind; rename resources-demo back to resources for lib css
Configuration menu - View commit details
-
Copy full SHA for c6be7e8 - Browse repository at this point
Copy the full SHA c6be7e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 414ced1 - Browse repository at this point
Copy the full SHA 414ced1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f3b1a8 - Browse repository at this point
Copy the full SHA 3f3b1a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d41d28c - Browse repository at this point
Copy the full SHA d41d28cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ad7921 - Browse repository at this point
Copy the full SHA 3ad7921View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf842ce - Browse repository at this point
Copy the full SHA bf842ceView commit details -
build: change ws-connect-url query param ELECTRIC_USER_VERSION sentin…
…el value for dev
Configuration menu - View commit details
-
Copy full SHA for 385d1c3 - Browse repository at this point
Copy the full SHA 385d1c3View commit details
Commits on Dec 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ef7add7 - Browse repository at this point
Copy the full SHA ef7add7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d8489d - Browse repository at this point
Copy the full SHA 3d8489dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c2f07 - Browse repository at this point
Copy the full SHA 03c2f07View commit details -
shadow dev reload hook: correctly skip first run
The previous strategy was flawed, we skipped the first reload of every file. A file loaded from cache will not recompile on first run. The new strategy is correct, we don't run the hook on first run.
Configuration menu - View commit details
-
Copy full SHA for 3f4f16a - Browse repository at this point
Copy the full SHA 3f4f16aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eeacba - Browse repository at this point
Copy the full SHA 5eeacbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e155a33 - Browse repository at this point
Copy the full SHA e155a33View commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 73c5419 - Browse repository at this point
Copy the full SHA 73c5419View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2228cd6 - Browse repository at this point
Copy the full SHA 2228cd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 951fbdc - Browse repository at this point
Copy the full SHA 951fbdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42e4f09 - Browse repository at this point
Copy the full SHA 42e4f09View commit details -
don't use assert, it can easily misalign the code when 1 peer has `*assert*` set to true and other to false
Configuration menu - View commit details
-
Copy full SHA for e9ce5c4 - Browse repository at this point
Copy the full SHA e9ce5c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 074a674 - Browse repository at this point
Copy the full SHA 074a674View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca53769 - Browse repository at this point
Copy the full SHA ca53769View commit details
Commits on Dec 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b721382 - Browse repository at this point
Copy the full SHA b721382View commit details
Commits on Dec 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b896a6a - Browse repository at this point
Copy the full SHA b896a6aView commit details -
Fix allow-large-shadow-cache hook
Would break build without Jackson on the classpath Hook is now a noop if Jackson is not on the classpath
Configuration menu - View commit details
-
Copy full SHA for f97308b - Browse repository at this point
Copy the full SHA f97308bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f951e9d - Browse repository at this point
Copy the full SHA f951e9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d309877 - Browse repository at this point
Copy the full SHA d309877View commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 89649d6 - Browse repository at this point
Copy the full SHA 89649d6View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7c17b77 - Browse repository at this point
Copy the full SHA 7c17b77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 784635a - Browse repository at this point
Copy the full SHA 784635aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b59bc32 - Browse repository at this point
Copy the full SHA b59bc32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 753f326 - Browse repository at this point
Copy the full SHA 753f326View commit details -
Changelog: macros expanding conditionally can cause client and server…
… programs to get misaligned
Configuration menu - View commit details
-
Copy full SHA for f5d066b - Browse repository at this point
Copy the full SHA f5d066bView commit details -
Adapt electric-fulcro adapter to new IC constraints
Electric-fulcro adapter used to run electric code inline, closing over lexical scope. Now : - one needs to pass values to electric explicitely - one cannot run multiple instances of a given electric program on a single fulcro page, i.e. one can run multiple electric programs on one page, but they cannot be the same electric program.
Configuration menu - View commit details
-
Copy full SHA for 68e8fc7 - Browse repository at this point
Copy the full SHA 68e8fc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8464499 - Browse repository at this point
Copy the full SHA 8464499View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31394d4 - Browse repository at this point
Copy the full SHA 31394d4View commit details -
Restore default JVM stack size
Larger stack size was required before IC. Not anymore.
Configuration menu - View commit details
-
Copy full SHA for 0a69668 - Browse repository at this point
Copy the full SHA 0a69668View commit details
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d5b5635 - Browse repository at this point
Copy the full SHA d5b5635View commit details
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0c582f7 - Browse repository at this point
Copy the full SHA 0c582f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c9bd83 - Browse repository at this point
Copy the full SHA 8c9bd83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b543d4 - Browse repository at this point
Copy the full SHA 4b543d4View commit details -
[breaking] Simpler websocket integration with ring-websocket
Electric Jetty and HTTPKit adapters are now based on latest Ring. Latest Ring (1.11+) support websockets out of the box. It is now simpler to: - integrate electric into existing ring apps, - extend the electric adapter over new HTTP servers. Breaking changes: - `hyperfiddle.electric-jetty-adapter` has been replaced by the simpler, generic `hyperfiddle.electric-ring-adapter`. - The API is simpler, smaller, but is not retrocompatible. - Code depending on `electric-jetty-adapter` must be updated. - `hyperfiddle.electric-httpkit-adapter` is now based on `electric-ring-adapter` and exposes the same API. The two namespaces are equivalent, they only differ on the underlying HTTP server. - Note latest ring-jetty depends on Jetty 11, which requires Java 11+ - Electric can run with Jetty 9 and Java 8 - We found no use case for Java 8 retro compatibility so far - If you need Jetty9 / Java 8 compat, see [electric-server-java-9-jetty-9](https://github.com/hyperfiddle/electric/blob/cc55772f18bc46373f131e092fc20055c8062b59/src-docs/electric_server_java8_jetty9.clj) and [electric-jetty-adapter](https://github.com/hyperfiddle/electric/blob/cc55772f18bc46373f131e092fc20055c8062b59/src/hyperfiddle/electric_jetty_adapter.clj) How to migrate: - Look at the integration for: - Jetty: [Electric jetty integration](https://github.com/hyperfiddle/electric-fiddle/blob/01b49391e38d2684a7cbf7f82fa58da503af5be8/src/electric_fiddle/server_jetty.clj) - HTTPKit [Electric httpkit integration](https://github.com/hyperfiddle/electric-fiddle/blob/01b49391e38d2684a7cbf7f82fa58da503af5be8/src/electric_fiddle/server_httpkit.clj) - update your ring middlewares accordingly
Configuration menu - View commit details
-
Copy full SHA for d41e0c1 - Browse repository at this point
Copy the full SHA d41e0c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a469953 - Browse repository at this point
Copy the full SHA a469953View commit details -
Configuration menu - View commit details
-
Copy full SHA for f074884 - Browse repository at this point
Copy the full SHA f074884View commit details
Commits on Jan 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ae2fe0 - Browse repository at this point
Copy the full SHA 5ae2fe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e9b4ed - Browse repository at this point
Copy the full SHA 5e9b4edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 173f8bb - Browse repository at this point
Copy the full SHA 173f8bbView commit details
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77a9172 - Browse repository at this point
Copy the full SHA 77a9172View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08540ce - Browse repository at this point
Copy the full SHA 08540ceView commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cda5268 - Browse repository at this point
Copy the full SHA cda5268View commit details
Commits on Jan 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 63f9aa4 - Browse repository at this point
Copy the full SHA 63f9aa4View commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c005ffc - Browse repository at this point
Copy the full SHA c005ffcView commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0571b5a - Browse repository at this point
Copy the full SHA 0571b5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91cc34a - Browse repository at this point
Copy the full SHA 91cc34aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fcec39 - Browse repository at this point
Copy the full SHA 3fcec39View commit details -
Fix router missing link clicks on fast click bursts
Clicking two links fast (a few milliseconds between two clicks) would trigger a hard navigation instead of being intercepted by the router and triggering a soft nav.
Configuration menu - View commit details
-
Copy full SHA for 79c2bbc - Browse repository at this point
Copy the full SHA 79c2bbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b32ac98 - Browse repository at this point
Copy the full SHA b32ac98View commit details
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dee3ec2 - Browse repository at this point
Copy the full SHA dee3ec2View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 54b423c - Browse repository at this point
Copy the full SHA 54b423cView commit details
Commits on Jan 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 923d328 - Browse repository at this point
Copy the full SHA 923d328View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12430dd - Browse repository at this point
Copy the full SHA 12430ddView commit details
Commits on Jan 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8ebfecc - Browse repository at this point
Copy the full SHA 8ebfeccView commit details
Commits on Jan 31, 2024
-
Fix "connection was interrupted while the page was loading" error on …
…tab wakeup Browsers will send a WS PING frame on tab wakeup to check if the socket is still open. We forgot to answer pings with pongs. A tab can wake up when: - The user focused it after it's been in the background for a while, - The laptop lid is opened - User interact with the computer after the screen was sleeping (even if the computer itself was not sleeping)
Configuration menu - View commit details
-
Copy full SHA for 7b81126 - Browse repository at this point
Copy the full SHA 7b81126View commit details -
Jetty leverages WS control frames for heartbeat
Cleaner design. HTTPKit doesn't support it, so we emulate it.
Configuration menu - View commit details
-
Copy full SHA for ae1341b - Browse repository at this point
Copy the full SHA ae1341bView commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 689f5c4 - Browse repository at this point
Copy the full SHA 689f5c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f877679 - Browse repository at this point
Copy the full SHA f877679View commit details -
Inform users of misaligned client/server DAGs
This was a chaotic situation where both users and us would get confused. This got us so confused it triggered multiple meetings. Solution: detect the situation and orient the user about: - what is happening, - what to do if this happens in prod. We also kill the ws connection and inform the electric client to NOT attempt to reconnect to avoid a broken program reconnection loop.
Configuration menu - View commit details
-
Copy full SHA for 91fd468 - Browse repository at this point
Copy the full SHA 91fd468View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for cf794bf - Browse repository at this point
Copy the full SHA cf794bfView commit details -
Document browser WS connect throttling
Electric client was trying to reconnect after 100ms, 100ms, 200ms, 300ms, ... This sometimes trigger a browser safety feature in dev mode after a few fast page refresh. I decided to drop the first 100ms connection attempt to save on reconnection attempts, without making the initial reconnection attempt slower.
1Configuration menu - View commit details
-
Copy full SHA for e53bc89 - Browse repository at this point
Copy the full SHA e53bc89View commit details
Commits on Feb 12, 2024
-
Improved client websocket disconnect messages
No red errors No stack traces Explicit messages
Configuration menu - View commit details
-
Copy full SHA for 4271040 - Browse repository at this point
Copy the full SHA 4271040View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cfb984 - Browse repository at this point
Copy the full SHA 0cfb984View commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51de4f5 - Browse repository at this point
Copy the full SHA 51de4f5View commit details
Commits on Mar 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 72b9428 - Browse repository at this point
Copy the full SHA 72b9428View commit details