Add nil check for knowledge base inside execute and fetch matching rule methods #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing a nil knowledgebase to exceute or fetch matching rules method was resulting in a panic which took some time to find, adding a nil check for both of these methods to throw proper error in this case added unit tests for the same
|
fixes #397 |
|
Hi @Pandey-SaurabhP , I have read your changes and completely understand the Idea. I try to merge your code but it seems to fail. Its not your fault because your code pull request based on the code base that gone through big change. However, I have copied your code and merge it in. Its now in master but not yet released. It will be released ASAP. |
|
thanks :) |
Hi @Pandey-SaurabhP , By this fix, can we able to find the causing error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passing a nil knowledgebase to exceute or fetch matching rules method was resulting in a panic which is little hard to find, adding a nil check for both of these methods to throw proper error in case a nil kb is passed
added unit tests for the same to verify the fix