[ci-skip] move hashicorp vault functions to a single script #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit decouples the vault related functionality from individual helm charts by utilizing the bevel-vault.sh script. Changes Made: • Removed vault-related code from individual Quorum Helm charts. • Updated all Helm charts to utilize the shared bevel-vault.sh script. • Improved code quality by fixing if-conditions defined in the shared bevel-vault.sh script. • Deleted the node_quorum Helm chart and its quorum.tpl template file because they are not being used. Instead, we always use the node_quorum_member Helm chart for the same purpose. These changes will improve code maintainability and efficiency by reducing code duplication and making it easier to maintain consistency. fixes #2323 Signed-off-by: saurabhkumarkardam <saurabh.kumar.kardam@accenture.com>
saurabhkumarkardam
requested review from
sownak,
suvajit-sarkar,
jagpreetsinghsasan,
arsulegai,
weihong-ou and
adityajoshi12
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(quorum): move hashicorp vault functions to a single script
fixes #2323