Add more test for tx observers #1617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklenik
added
the
mentorship-2024-testing
davidkel
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Unfortunately I think that there is too much in this PR. I think it would be easier to review if we have much smaller PRs and each PR should focus on a single unit (ie .js file under test). If we do it this way I think it will be easier to focus and also we can get code merged more quicky. Please could you split the PR into multiple ones
packages/caliper-core/lib/worker/tx-observers/logging-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/lib/worker/tx-observers/tx-observer-dispatch.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/lib/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
tunedev
force-pushed
the
add-more-test-for-tx-observers
branch
3 times, most recently
from
da53eeb
to
d054b8e
Compare
…s folder: internal-tx-observers logging-tx-observers prometheus-tx-observer tx-observer-dispatch Signed-off-by: Babatunde Sanusi <swisskid95@gmail.com>
tunedev
force-pushed
the
add-more-test-for-tx-observers
branch
from
d054b8e
to
dcc156f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue/User story
Partially addresses #1606
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
After this PR: Running the tests in caliper-core the below listed %stmts in the code coverage report should tally with the below listed
Before the PR: Running the tests in caliper-core the below listed %stmts in the code coverage report the below listed was what was there before
Automated Tests
What documentation has been provided for this pull request