add test for caliper-engine module #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunedev
force-pushed
the
add-test-to-manager-caliper-engine-module
branch
from
05f794e
to
bf0217f
Compare
Signed-off-by: Babatunde Sanusi <swisskid95@gmail.com>
tunedev
force-pushed
the
add-test-to-manager-caliper-engine-module
branch
from
bf0217f
to
4dd0f33
Compare
davidkel
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
I still don't like text such as should handle errors as we should describe exactly how it handles errors. I want to be able to read this and know what I expect the code to be doing and where possible that test to validate it. However given the time left I think we should look to fix these descriptions in the implementation PR. So going to approve this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue/User story
Closes #1637
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
Automated Tests
What documentation has been provided for this pull request