Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throughput faq #1656

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: throughput faq #1656

merged 3 commits into from
Nov 22, 2024

Conversation

psankhe28
Copy link
Contributor

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

#1418

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to add send rate back in

Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there, have done some tidyup to provide a recommendation.

docs/source/getting-started/faq.md Outdated Show resolved Hide resolved
Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Many thanks

@davidkel davidkel merged commit 19d46db into hyperledger-caliper:main Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants