Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reorganise workflows [EXPERIMENTAL] #5125

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Oct 4, 2024

Context

This is built on top of #5124 as an experiment to see if our CI could look more organised. I am confused each time looking at different workflows and their jobs and determining what is what.

Partially closes #4516

Solution

Remove old workflows; combine some; simpler names.

Migration Guide (optional)


Review notes (optional)

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@0x009922 0x009922 added the CI label Oct 4, 2024
@0x009922 0x009922 self-assigned this Oct 4, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Oct 4, 2024
@0x009922
Copy link
Contributor Author

0x009922 commented Oct 4, 2024

What is the difference between publish_what.yml and publish_what2.yml?

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>

fix: lints, correct upload of `executor.wasm`

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>

fix: make `iroha_core` compile without `telemetry` feature

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>

ci: copy executor from script; debug; single test command

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>

ci: remove debug, enable full tests

And remove extra `iroha_wasm_builder` dependency

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 force-pushed the ci/reorganise-workflows branch from 1fce139 to 2bed378 Compare October 9, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise CI - reduce flakyness, unify workflows
1 participant