Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error prevs commit #599

Merged
merged 1 commit into from
Oct 13, 2024
Merged

fix error prevs commit #599

merged 1 commit into from
Oct 13, 2024

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Oct 11, 2024

No description provided.

@pfi79 pfi79 requested a review from yacovm October 11, 2024 15:40
@pfi79 pfi79 mentioned this pull request Oct 11, 2024
Closed
yacovm
yacovm requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@yacovm yacovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you add a commit message?
  2. Can you please add a test that checks that when we send pre-prepare, we don't only attach the previous commit signatures when periodical leader rotation is enabled?

@pfi79 pfi79 force-pushed the fix-error-prev-commits branch 2 times, most recently from 5f8fbf3 to 91d443d Compare October 13, 2024 17:13
@pfi79
Copy link
Contributor Author

pfi79 commented Oct 13, 2024

  1. Can you add a commit message?
  2. Can you please add a test that checks that when we send pre-prepare, we don't only attach the previous commit signatures when periodical leader rotation is enabled?

done

yacovm
yacovm reviewed Oct 13, 2024
View reviewed changes
internal/bft/view_test.go Outdated
comm := &mocks.CommMock{}
commWG := sync.WaitGroup{}
comm.On("BroadcastConsensus", mock.Anything).Run(func(args mock.Arguments) {
fmt.Println("Sending", args.Get(0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the print

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, my inattention.

Fixed it.

@pfi79
prevCommitSignatures is added to the prePrepare message only when lea…
2917046 
…der rotation is on

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@pfi79 pfi79 requested a review from yacovm October 13, 2024 18:25
@yacovm yacovm merged commit 134292d into main Oct 13, 2024
6 checks passed
@pfi79 pfi79 deleted the fix-error-prev-commits branch October 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacovm yacovm yacovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfi79 @yacovm