Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws and cypress-watch-and-reload in /packages/apollo/test/cypress #765

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 28, 2024

Bumps ws to 8.17.1 and updates ancestor dependency cypress-watch-and-reload. These dependencies need to be updated together.

Updates ws from 8.14.2 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates cypress-watch-and-reload from 1.10.9 to 1.10.15

Release notes

Sourced from cypress-watch-and-reload's releases.

v1.10.15

1.10.15 (2024-06-16)

Bug Fixes

  • deps: update dependency ws to v8.17.1 (e99941b)

v1.10.14

1.10.14 (2024-04-28)

Bug Fixes

  • deps: update dependency ws to v8.17.0 (a0d8888)

v1.10.13

1.10.13 (2024-02-07)

Bug Fixes

  • deps: update dependency chokidar to v3.6.0 (6ecdc1c)

v1.10.12

1.10.12 (2023-12-26)

Bug Fixes

  • deps: update dependency ws to v8.16.0 (a89be7e)

v1.10.11

1.10.11 (2023-12-13)

Bug Fixes

  • deps: update dependency ws to v8.15.1 (2b4cba3)

v1.10.10

1.10.10 (2023-12-09)

Bug Fixes

  • deps: update dependency ws to v8.15.0 (91c5bc3)
Commits
  • e99941b fix(deps): update dependency ws to v8.17.1
  • a0d8888 fix(deps): update dependency ws to v8.17.0
  • 6ecdc1c fix(deps): update dependency chokidar to v3.6.0
  • a89be7e fix(deps): update dependency ws to v8.16.0
  • 2b4cba3 fix(deps): update dependency ws to v8.15.1
  • 91c5bc3 fix(deps): update dependency ws to v8.15.0
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependency [cypress-watch-and-reload](https://github.com/bahmutov/cypress-watch-and-reload). These dependencies need to be updated together.


Updates `ws` from 8.14.2 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.14.2...8.17.1)

Updates `cypress-watch-and-reload` from 1.10.9 to 1.10.15
- [Release notes](https://github.com/bahmutov/cypress-watch-and-reload/releases)
- [Commits](bahmutov/cypress-watch-and-reload@v1.10.9...v1.10.15)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: cypress-watch-and-reload
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 28, 2024
@dependabot dependabot bot requested a review from a team as a code owner June 28, 2024 12:35
@ketulsha
Copy link
Contributor

Addressed in #776

@ketulsha ketulsha closed this Aug 16, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 16, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/packages/apollo/test/cypress/multi-859084963f branch August 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant