Introduce capability for publishing error Records to Dead letter topic #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: “Nithin <nithin.pankaj@walmartlabs.com>
nithin-pankaj
force-pushed
the
deadletter-publish
branch
from
e109055
to
17d7499
Compare
abhakish
reviewed
Nov 16, 2023
Comment on lines
55
to
67
| KafkaTemplate<String, String> deadLetterPublisherTemplate = | ||
| new KafkaTemplate<>( | ||
| kafkaProducerConfig.eventProducerFactory(kafkaProperties.getFailedMessageListener())); | ||
|
|
||
| // Set the exclusive dead letter topic | ||
| deadLetterPublisherTemplate.setDefaultTopic( | ||
| kafkaProperties.getFailedMessageListener().getTopic()); | ||
| deadLetterPublishingRecoverer = | ||
| new DeadLetterPublishingRecoverer( | ||
| deadLetterPublisherTemplate, | ||
| (cr, e) -> | ||
| new TopicPartition( | ||
| kafkaProperties.getFailedMessageListener().getTopic(), cr.partition())); |
There was a problem hiding this comment.
[nitpick] a method can be extracted for these lines as only listener is different and rest is same in both scenarios
There was a problem hiding this comment.
Makes sense. Done.
| @@ -20,7 +20,8 @@ | |||
| public class KafkaProperties { | |||
|
|
|||
| private List<Consumer> integrationPoints; | |||
| private Producer eventListener; | |||
| private EventProducer eventListener; | |||
| private Producer failedMessageListener; | |||
There was a problem hiding this comment.
Can you add the application.yml change for this in application.template file
added 5 commits
November 16, 2023 16:20
…ge consumption Signed-off-by: “Nithin <nithin.pankaj@walmartlabs.com>
Signed-off-by: “Nithin <nithin.pankaj@walmartlabs.com>
Signed-off-by: “Nithin <nithin.pankaj@walmartlabs.com>
Signed-off-by: “Nithin <nithin.pankaj@walmartlabs.com>
Signed-off-by: “Nithin <nithin.pankaj@walmartlabs.com>
nithin-pankaj
force-pushed
the
deadletter-publish
branch
from
17d7499
to
cfda8e5
Compare
nithin-pankaj
force-pushed
the
deadletter-publish
branch
from
cfda8e5
to
2183d13
Compare
Signed-off-by: “Nithin <nithin.pankaj@walmartlabs.com>
nithin-pankaj
force-pushed
the
deadletter-publish
branch
from
2183d13
to
f08ca4d
Compare
abhakish
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes for publishing failed consumer Records polled from the Integration topic(s) to a configured error Event listener Topic.
The changes would effectively allow the Connector to publish the Error record to a topic based on the following criteria :-
listenToFailedMessagesset as true, the failed message will be published back to Event listener topic (this is the current behaviour).listenToFailedMessagesis set to true as well as a dedicated Dead letter topic is configured, the dead letter topic will take priority and record will be dispatched to it.