Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New minor version of Present Proof that supports asking for and responding with multiple presentations for the same presentation request #689

Merged
merged 2 commits into from
Jul 14, 2021
Merged

New minor version of Present Proof that supports asking for and responding with multiple presentations for the same presentation request #689

merged 2 commits into from
Jul 14, 2021

Conversation

swcurran
Copy link
Member

Addresses #681

@swcurran
New minor version of Present Proof that supports asking for and respo…
8d79876 
…nding with multiple presentations for the same presentation request

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Member Author

FYI -- @mattraffel @jsaur

TimoGlastra
TimoGlastra approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. I'm not 100% up to date on the use case, but wouldn't it be easier to require all proofs to be included in the same presentation message?

so presentations~attach will contain multiple entries for the same format.

@TelegramSam TelegramSam merged commit 97fc8c7 into hyperledger:master Jul 14, 2021
@swcurran swcurran deleted the present-proof-multi branch August 10, 2021 21:12
@swcurran swcurran mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

@TelegramSam TelegramSam TelegramSam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swcurran @TelegramSam @TimoGlastra