Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix some AATH flow where a connection does not yet exist #1280

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

gmulhearn
Copy link
Contributor

continues from changes in #1278, with a small change to not use the "get connection by sender" API, since the connection may not exist in some contexts.

This should fix the recent AATH issue being reported by @nodlesh :

riesVCX Error: Error: Error: POST failed due to non-success HTTP status: 500 Internal Server Error, response body: Error: AgentError: Invalid state: Found no connections by sender's verkey 4rBrKy5znEKSvePtLjsv8ws2ERteF6vjcdabb1PxtrkL
  
�[90m[�[0m2024-08-05T03:14:02Z �[1m�[31mERROR�[0m aries_vcx_backchannel::error�[90m]�[0m Error: AgentError: AriesVCX error: AriesVCX Error: Error: Error: POST failed due to non-success HTTP status: 500 Internal Server Error, response body: Error: AgentError: Invalid state: Found no connections by sender's verkey 4rBrKy5znEKSvePtLjsv8ws2ERteF6vjcdabb1PxtrkL

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Copy link

@nodlesh nodlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't run the tests, so we will see in the nightly runs.

Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a quick review, but I did not run the tests

@gmulhearn gmulhearn merged commit 1837081 into hyperledger:main Aug 7, 2024
22 checks passed
alberto-instnt pushed a commit to instnt-inc/instnt-aries-vcx that referenced this pull request Sep 10, 2024
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Co-authored-by: George Mulhearn <gmulhearn@anonyome.com>
alberto-instnt pushed a commit to instnt-inc/instnt-aries-vcx that referenced this pull request Sep 10, 2024
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Co-authored-by: George Mulhearn <gmulhearn@anonyome.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants