Support JWK public key VM processing into Key #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
gmulhearn
changed the title
Signed-off-by: gmulhearn <gmulhearn@proton.me>
|
Apparently there's some minor conflicts present on this one |
Signed-off-by: George Mulhearn <57472912+gmulhearn@users.noreply.github.com>
gmulhearn
dismissed
JamesKEbert’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1289
Decided to use askar-crypto for processing JWK in simplest way possible, did not want to try process the keys myself, and couldn't find another smaller crate that was suitable.
For now I've made this feature optional via
jwkfeature-flag which a consumer can optionally enable. Didn't want to force a requirement on askar-crypto for a relatively small crate (public_key).