Install cargo via rustup in alpine image #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
|
Additional background info |
Patrik-Stas
previously approved these changes
Jul 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 49.72% 49.72%
=======================================
Files 156 156
Lines 19634 19634
Branches 6205 6205
=======================================
Hits 9763 9763
Misses 5070 5070
Partials 4801 4801
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I don't know why the changes trigger this error, but the problem might disappear with these changes #317 |
mirgee
force-pushed
the
hotfix/rustc-version-in-docker-image
branch
2 times, most recently
from
f3268d0
to
0b71ea8
Compare
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
mirgee
force-pushed
the
hotfix/rustc-version-in-docker-image
branch
from
0b71ea8
to
b0c879e
Compare
Patrik-Stas
reviewed
Jul 14, 2021
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Patrik-Stas
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo has been installed via apk until now, limiting us with regards to the toolchain version we used to compile our images. Via rustup, we have more freedom to choose the toolchain version.
Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com