Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability of migrating wallet through the node.js wrapper (#895) #919

Closed
wants to merge 1 commit into from

Conversation

Patrik-Stas
Copy link
Contributor

We have previously reverted #906 feature to expose wallet migration in nodejs wrapper. This brings the code back - reverts the revert.

  • Added capability of migrating wallet through the node.js wrapper

@Patrik-Stas Patrik-Stas force-pushed the nodejs/migration branch 2 times, most recently from cf1e32f to 527272d Compare July 29, 2023 15:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Merging #919 (1272dac) into main (7558c3d) will increase coverage by 14.59%.
The diff coverage is 57.83%.

❗ Current head 1272dac differs from pull request most recent head 50b7636. Consider uploading reports for the commit 50b7636 to get more accurate results

@@             Coverage Diff             @@
##             main     #919       +/-   ##
===========================================
+ Coverage   29.76%   44.35%   +14.59%     
===========================================
  Files         411      415        +4     
  Lines       26070    29228     +3158     
  Branches     5315     6252      +937     
===========================================
+ Hits         7760    12965     +5205     
+ Misses      16001    12436     -3565     
- Partials     2309     3827     +1518     
Flag Coverage Δ
unittests-aries-vcx 44.35% <57.83%> (+14.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/src/common/keys.rs 44.64% <ø> (ø)
...es_vcx/src/common/proofs/prover/prover_internal.rs 27.27% <ø> (ø)
aries_vcx/src/common/proofs/verifier/verifier.rs 81.64% <0.00%> (ø)
aries_vcx/src/common/test_utils.rs 93.54% <ø> (-0.68%) ⬇️
aries_vcx/src/core/profile/mod.rs 0.00% <ø> (ø)
aries_vcx/src/core/profile/modular_libs_profile.rs 0.00% <0.00%> (-70.74%) ⬇️
aries_vcx/src/utils/constants.rs 0.00% <ø> (ø)
...ries_vcx/src/utils/mockdata/profile/mock_ledger.rs 0.00% <0.00%> (ø)
aries_vcx/tests/utils/devsetup_util.rs 48.71% <ø> (ø)
aries_vcx_core/src/ledger/indy/pool.rs 83.87% <ø> (ø)
... and 28 more

... and 256 files with indirect coverage changes

* Added capability of migrating wallet through the node.js wrapper

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants