fix(aries-vcx): fixed dependency listing in README for Cargo.toml

[arminveres]

Using path does not work and crates from git sources need be specified through git=....

[Patrik-Stas]

hi @arminveres thanks for the fix!

By Hyperledger policy, all commits must be signed off (DCO) - which basically every commit message must contain following bottom line (example):

    Add integration test to nodejs wrapper
    
    Signed-off-by: John Doe <john.doe@example.org>    

there's a switch in git to help you do this --signoff. You can fix your PR like this:

git commit --signoff --amend

and then push force the branch.

Thank you!

[Patrik-Stas]

@arminveres by the way, what we should probably also mention in the readme, it's highly recommended to fix the revision of the dependency, so you are not simply fetching the latest main branch (eg. adding ver field specification for the dependency in cargo.toml)

[arminveres]

Thanks @Patrik-Stas, I amended the commit and included a version tag. Should I be more verbose about it?

[Patrik-Stas]

@arminveres thanks for prompt DCO fix, but note that the example is currently not quite valid. version is not valid attribute when dealing with git dependencies - have a look at this https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories

You can combine the git key with the rev, tag, or branch keys

[arminveres]

I see, you are right, it built on my system, but it ignored the version tag and proceeded to use the latest tag available, so I didn't notice it. I adjusted the commit. Thanks!

[codecov-commenter]

Codecov Report

Merging #924 (fcc4d28) into main (e167ed3) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head fcc4d28 differs from pull request most recent head 4dd596e. Consider uploading reports for the commit 4dd596e to get more accurate results

@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   43.33%   43.34%           
=======================================
  Files         438      438           
  Lines       34847    34847           
  Branches     7609     7609           
=======================================
+ Hits        15101    15103    +2     
+ Misses      15263    15260    -3     
- Partials     4483     4484    +1     

Flag	Coverage Δ
unittests-aries-vcx	43.34% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

[Patrik-Stas]

Thanks @arminveres, looks good, merging.

By the way, I am curious to ask, are you looking to build some using aries-vcx, or are you yet just looking around? Let me know if you'd need some support; also we have discord and weekly community calls

[arminveres]

Thanks @arminveres, looks good, merging.

By the way, I am curious to ask, are you looking to build some using aries-vcx, or are you yet just looking around? Let me know if you'd need some support; also we have discord and weekly community calls

Thanks!
I am working on my thesis and I am planning on using Aries, also possibly other parts of Hyperledger. I have already joined the discord. I will surely need support, its a tad overwhelming with so many repos and frameworks to go through! Thanks again!