Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rocksdb jni lib from 8.3.2 to 9.7.3 #7817

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented Oct 28, 2024

PR description

Upgrade rocksdb jni lib from 8.3.2 to 9.7.3

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
@ahamlat ahamlat force-pushed the upgrade-rocksdb-jni-to-9-7-3 branch from 76c0008 to 54aa48b Compare October 28, 2024 14:06
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
@ahamlat ahamlat marked this pull request as ready for review October 28, 2024 15:06
@macfarla
Copy link
Contributor

where's this one at in terms of testing @ahamlat ?

@ahamlat
Copy link
Contributor Author

ahamlat commented Oct 31, 2024

@macfarla still testing, I'm OOO so let's keep it open until I share the results

@macfarla
Copy link
Contributor

macfarla commented Nov 3, 2024

@macfarla still testing, I'm OOO so let's keep it open until I share the results

I'm changing to DRAFT as we're waiting for test results

@macfarla macfarla marked this pull request as draft November 3, 2024 23:14
@ahamlat
Copy link
Contributor Author

ahamlat commented Nov 4, 2024

I see no difference in terms of block processing performance between both versions.

image

But version 9.7.3 seems to use more memory compared to 8.3.2

image

Which is related to off heap allocations

image

I'm also checking this old comment // 8.9.1 causes a bug with a FOREST canary on forest nodes

@ahamlat
Copy link
Contributor Author

ahamlat commented Nov 20, 2024

Running the nodes for more almost 2 weeks showed similar memory usage between the two versions of RocksDB. Off-heap memory is also very close.

image

Signed-off-by: ahamlat <ameziane.hamlat@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants