remove --host-whitelist option issue #7761 #7847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marlene Marz <m.marz@kabelmail.de> remove --host-whitelist option
JanetMo
force-pushed
the
Remove---host-whitelist
branch
from
3cff3da
to
214cc1b
Compare
|
@JanetMo thanks for your PR - you should be able to revert the changes to the docker-compose file to remove that from this PR. Also I think RetestethSubCommand has been deleted in the meantime, so you've got a conflict there |
macfarla
reviewed
Nov 6, 2024
|
Thanks @macfarla for the update! We reverted the changes to the docker-compose file and solved the merge conflict, we weren't able to signoff some of the commits though. Do you have an idea, how to sign previous commits (we tried to rebase)? The changelog was already updated previously by @jflo I believe. |
|
details on how to correct a DCO situation can be found on the failing DCO action: https://github.com/hyperledger/besu/pull/7847/checks?check_run_id=32756293076 |
Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* chore:Removed Dupicate AcceptanceTestBase Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…l String on REVERT (hyperledger#7774) Signed-off-by: 7at <itisfor@outlook.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* removed dep for testcontainers Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…PI (hyperledger#7832) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* Make timeout feature use vertx timer. * Handle all errors resulting from timeout. * Ensure that after the timeout occurs, we properly handle the response and don't allow the execution to continue. --------- Signed-off-by: Ade Lucas <ade.lucas@consensys.net> Signed-off-by: cloudspores <ade.lucas@consensys.net> Co-authored-by: Ade Lucas <adelucas@gc950powy.lan> Co-authored-by: Ade Lucas <adelucas@macbook-pro.lan> Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: monem <119044801+pucedoteth@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…r#7837) Also change "Missing" -> "Unexpected" message when V3 blob params sent to V2 Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* remove retesteth rpc service and commands Signed-off-by: garyschulte <garyschulte@gmail.com>
decoupled parent block header from block creators optionalized some fields of ProtocolSchedule constructor, which will allow us to reduce number of constructors later. Refactored JsonBlockImporterTest so it can provide a BesuComponent ProtocolScheduleBuilder optionalizes the default chainid Blocks SubCommand is now Dagger aware Creates but rarely uses ProtocolSpec and ProtocolSchedule modules. Deeper adoption pending. Adds a Coinbase module with fixed values for use in testing. Introduces an EthereumCoreComponent, to be used as a subcomponent of BesuComponent in the future. Introduces a MiningParameters module with common static values used by tests. Removes MiningParameters static constructor. --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* adds issue templates Signed-off-by: jflo <justin+github@florentine.us> * adopts pr suggestions Signed-off-by: jflo <justin+github@florentine.us> --------- Signed-off-by: jflo <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…ger#7821) * add optional worldstate move to debug_setHead * make state rolling occur incrementally so as not to overwhelm memory and resources Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…yperledger#7834) * fix(push): right pad if push parameter exceeds code length * test: add push operation padding tests * better perf rightPadding thnks to Ameziane Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch> Co-authored-by: Ameziane H. <ameziane.hamlat@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* fixes hyperledger#7749 Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com> * tests Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com> * spotless format fix Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com> --------- Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…dger#7860) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: wangjingcun <wangjingcun@aliyun.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* Fix incorrect duration for THREE_MINUTES from 1 minute to 3 minutes Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Add options to enable TLS/mTLS for websocket connections Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Revert an irrelevant change Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Update tests, options and option dependencies Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Fix CHANGELOG entry Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Fix CHANGELOG entry Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…fications (hyperledger#7858) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
"ope.ex.mem" should be "op.ex.mem" — The abbreviation for "opcode execution" should be "op" rather than "ope." Corrected. Signed-off-by: Dmitry <98899785+mdqst@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
* Implementing Issue hyperledger#7047 - Optionally load jemalloc Signed-off-by: Antonio Mota <antonio.mota@citi.com> * Implementing Issue hyperledger#7047 - Optionally load jemalloc Signed-off-by: Antonio Mota <antonio.mota@citi.com> * Implementing Issue hyperledger#7047 - Optionally load jemalloc: fixes after review Signed-off-by: Antonio Mota <antonio.mota@citi.com> * Implementing Issue hyperledger#7047 - Optionally load jemalloc: added entry to CHANGELOG Signed-off-by: Antonio Mota <antonio.mota@citi.com> * Changes after review Signed-off-by: Antonio Mota <antonio.mota@citi.com> * Added env var check in unix script Signed-off-by: Antonio Mota <antonio.mota@citi.com> * Improved code and script, build and tested Signed-off-by: amsmota <amsmota@gmail.com> * Improved code and script, build and tested Signed-off-by: amsmota <amsmota@gmail.com> --------- Signed-off-by: Antonio Mota <antonio.mota@citi.com> Signed-off-by: amsmota <amsmota@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
…#7878) * Upgrade netty to 4.1.115 (latest version) to resolve CVE Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update changelog Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
JanetMo
force-pushed
the
Remove---host-whitelist
branch
from
6f6e503
to
103fbe8
Compare
|
@jflo Thanks for the help. We tried rebasing, but it seems to have made it worse.... Should I just start over with a fresh PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the --host-whitelist option, issue #7761
deleted the command and it's associated tests, we however did not manage to test / build
(unfortunately, automatically added some beauty changes in benchmark/docker-compose.yml)