Move EIP-4762 gas charging for contract account creation from code su… #7869
+139
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessfully created to transaction start Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
lu-pinto
force-pushed
the
fix-eip-4762-gas-charge-contract-creation
branch
from
a525c77
to
cc7201a
Compare
matkt
reviewed
Nov 7, 2024
| @@ -288,6 +288,7 @@ public long touchAddressAndChargeGas( | |||
| final int accessMode) { | |||
| final short accessEvents = touchAddress(address, treeIndex, subIndex, accessMode); | |||
| long gas = 0; | |||
| LOG.atDebug().log(">>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>"); | |||
There was a problem hiding this comment.
To me it is useful for debugging because it tells me what has been charged in a single touch call, because we could have multiple charges in one call.
Maybe we can do a pretty print at the end to show this information at once instead. I'll have a look
| @@ -368,7 +369,7 @@ public long touchAddressAndChargeGas( | |||
| + " " | |||
| + gasView); | |||
| } | |||
|
|
|||
| LOG.atDebug().log("<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<"); | |||
| String.format( | ||
| "Not enough gas to cover proof of absence fee for %s: remaining gas = %d < %d = creation fee", | ||
| frame.getContractAddress(), frame.getRemainingGas(), statelessGasCost))) { | ||
| return; |
There was a problem hiding this comment.
do we need to return or set the state of the frame as we do here ?
frame.setExceptionalHaltReason(Optional.of(ExceptionalHaltReason.ILLEGAL_STATE_CHANGE));
frame.setState(MessageFrame.State.EXCEPTIONAL_HALT);
There was a problem hiding this comment.
is it Illegal state change? I think it is insufficient gas. It's already done inside handleInsufficientGas
…code successfully created to transaction start compact code for debug printing witness gas schedule Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
…code successfully created to transaction start update verkle reference tests build Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
matkt
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This fixes gas charges when creating contracts. While other clients charge the contract account creation while writing the nonce, besu was charging when the contract code was written to storage. A mismatch occurs if the code fails to deploy but the nonce is still written. In that case BASIC_DATA and CODE_HASH (empty contract hashcode) are still written to, despite code not being deployed.