Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Update Private-Txns-Migration.md #7870

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

mdqst
Copy link
Contributor

@mdqst mdqst commented Nov 8, 2024

PR description

The phrase "private transaction created using v1.3.4" should be in the plural form: "private transactions created using v1.3.4".

Corrected.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

mdqst and others added 2 commits November 8, 2024 13:11
The phrase "private transaction created using v1.3.4" should be in the plural form: "private transactions created using v1.3.4".

Corrected.

Signed-off-by: Dmitry <98899785+mdqst@users.noreply.github.com>
@macfarla macfarla enabled auto-merge (squash) November 19, 2024 06:12
@macfarla macfarla merged commit 37ea028 into hyperledger:main Nov 19, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants