Renaming state trie account for verkle integration #7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
garyschulte
approved these changes
Nov 22, 2024
Comment on lines
+69
to
+77
| /** | ||
| * The hash of the root of the storage trie associated with this account. | ||
| * | ||
| * @return the hash of the root node of the storage trie. | ||
| */ | ||
| @Override | ||
| public Hash getStorageRoot() { | ||
| return Hash.EMPTY_TRIE_HASH; | ||
| } |
There was a problem hiding this comment.
Should this be abstract, or even omitted in light of VerkleStateTrieAccountValue?
There was a problem hiding this comment.
for the moment it's returning EMPTY_TRIE_HASH because some generic code are still calling this method. I did some cleaning but it's not completly terminated . but in the future we will need to have it abstract indeed
There was a problem hiding this comment.
seems good to merge for now. we can revisit with the verkle branch merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Idea of this PR is to prepare integration of verkle by doing a small renaming of the state trie account value class and creating an abstract class for the common part between verkle and pmt
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests