Update shim version in integration test chaincodes #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Smith <benjsmi@us.ibm.com>
|
bestbeforetoday
changed the title
|
The build failure in this PR looks to have been caused by the change I made here. It is only picked up now because of the testing limitation described in issue #346. The question now is how best to fix this. We document in COMPATIBILITY.md that since v2.4 we target Java 11 as the runtime. However, we only required Java 8 at compile-time. We could either:
|
|
I have restored Java 8 chaincode support with PR #349. Once that is merged I will cut a v2.5.3 release. |
|
This will need to be redone with a PR that points at fabric-chaincode-shim v2.5.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a new Shim version 2.5.2, there's a couple of other examples that can point to it.